New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ack.future called when ack is null #646

Merged
merged 1 commit into from Apr 12, 2018

Conversation

Projects
None yet
3 participants
@oleg-py
Collaborator

oleg-py commented Apr 12, 2018

A bug from gitter with .delayOnNextBySelector. See unit test for previously-failing case.

@Avasil

Avasil approved these changes Apr 12, 2018

@codecov

This comment has been minimized.

codecov bot commented Apr 12, 2018

Codecov Report

Merging #646 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #646      +/-   ##
==========================================
- Coverage   90.95%   90.93%   -0.02%     
==========================================
  Files         377      377              
  Lines       10027    10028       +1     
  Branches     1876     1881       +5     
==========================================
- Hits         9120     9119       -1     
- Misses        907      909       +2
@Avasil

This comment has been minimized.

Collaborator

Avasil commented Apr 12, 2018

@alexandru alexandru merged commit 5ecf397 into monix:master Apr 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexandru

This comment has been minimized.

Member

alexandru commented Apr 12, 2018

Will get released in RC2 — hopefully on the 16-th.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment