New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Monix's rootdoc, the landing page for the ScalaDoc #653

Merged
merged 2 commits into from May 1, 2018

Conversation

Projects
None yet
2 participants
@Avasil
Collaborator

Avasil commented Apr 15, 2018

Fixes #611.

I wanted to contribute too and we have plenty of issues. :D

@Avasil Avasil added the scala-spree label Apr 15, 2018

@alexandru

This comment has been minimized.

Member

alexandru commented Apr 15, 2018

😄 🖖

rootdoc.txt Outdated
You can control evaluation with type you choose - be it [[monix.eval.Task Task]], [[monix.eval.Coeval Coeval]], [[https://typelevel.org/cats-effect/api/cats/effect/IO.html cats.effect.IO]]
or your own as long as you provide [[https://typelevel.org/cats-effect/typeclasses/sync.html cats.effect.Sync]] instance.

This comment has been minimized.

@alexandru

alexandru Apr 15, 2018

Member

Iterant isn't only about Sync, that's too specific. I think a simple mention of the cats-effect type classes should do.

This comment has been minimized.

@Avasil

Avasil Apr 15, 2018

Collaborator

Oh, right, depending on operations you use it could be just Applicative

@codecov

This comment has been minimized.

codecov bot commented Apr 15, 2018

Codecov Report

Merging #653 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #653      +/-   ##
==========================================
- Coverage   90.96%   90.89%   -0.07%     
==========================================
  Files         377      377              
  Lines       10028    10028              
  Branches     1881     1881              
==========================================
- Hits         9122     9115       -7     
- Misses        906      913       +7

@alexandru alexandru merged commit 93372cc into monix:master May 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Avasil Avasil deleted the Avasil:rootdoc-iterant-update branch Sep 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment