New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle InterruptedException in NonFatal #655

Merged
merged 2 commits into from Apr 15, 2018

Conversation

Projects
None yet
2 participants
@kubukoz
Contributor

kubukoz commented Apr 15, 2018

Fixes #645, so far it's using a shared implementation, but could be changed to have a separate one for JS and JVM worlds.

@Avasil Avasil added the scala-spree label Apr 15, 2018

@codecov

This comment has been minimized.

codecov bot commented Apr 15, 2018

Codecov Report

Merging #655 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #655      +/-   ##
==========================================
+ Coverage   90.96%   90.97%   +0.01%     
==========================================
  Files         377      377              
  Lines       10028    10030       +2     
  Branches     1881     1885       +4     
==========================================
+ Hits         9122     9125       +3     
+ Misses        906      905       -1
@Avasil

This comment has been minimized.

Collaborator

Avasil commented Apr 15, 2018

Thanks @kubukoz !

@alexandru I'm merging this, if we decide to go different route with NonFatal (like triggering cancelation) we can always do another change

@Avasil Avasil merged commit 0b0fdaf into monix:master Apr 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kubukoz kubukoz deleted the kubukoz:interrupt-interrupted branch Apr 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment