New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TaskApp scheduler and options defs #660

Merged
merged 1 commit into from Apr 24, 2018

Conversation

Projects
None yet
2 participants
@oleg-py
Collaborator

oleg-py commented Apr 22, 2018

We discussed this at gitter a while ago

Benefits of using defs:

  • You can override them with an implicit val, which is quite relevant for options after #634. Doing so will make ConcurrentEffect[Task] instance materializable with expected configuration.
  • You can do simple alterations by doing super, e.g.
override val scheduler = super.scheduler.withExecutionModel(AlwaysAsyncExecution)
override val options = super.options.enableLocalContextPropagation
@codecov

This comment has been minimized.

codecov bot commented Apr 22, 2018

Codecov Report

Merging #660 into master will increase coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
+ Coverage   91.02%   91.04%   +0.01%     
==========================================
  Files         377      377              
  Lines       10031    10031              
  Branches     1882     1890       +8     
==========================================
+ Hits         9131     9133       +2     
+ Misses        900      898       -2

@alexandru alexandru merged commit 840aef4 into monix:master Apr 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexandru

This comment has been minimized.

Member

alexandru commented Apr 24, 2018

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment