New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uncancelable to example #669

Merged
merged 2 commits into from May 8, 2018

Conversation

Projects
None yet
2 participants
@RaasAhsan
Contributor

RaasAhsan commented May 7, 2018

No description provided.

@RaasAhsan

This comment has been minimized.

Contributor

RaasAhsan commented May 7, 2018

Maybe rename the cancelable Task to uncancelable too?

@codecov

This comment has been minimized.

codecov bot commented May 7, 2018

Codecov Report

Merging #669 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #669      +/-   ##
==========================================
- Coverage   90.89%   90.88%   -0.01%     
==========================================
  Files         377      377              
  Lines       10089    10089              
  Branches     1900     1900              
==========================================
- Hits         9170     9169       -1     
- Misses        919      920       +1
@Avasil

Avasil approved these changes May 8, 2018

@Avasil

This comment has been minimized.

Collaborator

Avasil commented May 8, 2018

Thanks @RaasAhsan :)

@Avasil Avasil merged commit f3f2ba1 into monix:master May 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment