New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Make Task#start fork; deprecate Task#fork #685

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@oleg-py
Collaborator

oleg-py commented Jul 3, 2018

Currently failing tests:

In monix.eval.TaskConversionsSuite:

  • Task.fromEffect(task.to[IO]) preserves cancelability

In monix.eval.TypeClassLawsForTaskAutoCancelableRunSyncUnsafeSuite:

  • ConcurrentEffect[Task].concurrentEffect.runCancelable start.flatMap(_.cancel) coherence
  • ConcurrentEffect[Task].concurrentEffect.release of bracket is not cancelable
  • ConcurrentEffect[Task].concurrentEffect.asyncF registration can be cancelled
  • ConcurrentEffect[Task].concurrentEffect.async cancelable receives cancel signal
  • ConcurrentEffect[Task].concurrentEffect.acquire of bracket is not cancelable
@alexandru

This comment has been minimized.

Show comment
Hide comment
@alexandru

alexandru Jul 5, 2018

Member

@oleg-py you actually uncovered a problem either with how start should behave, or with the Cats-Effect laws.

Member

alexandru commented Jul 5, 2018

@oleg-py you actually uncovered a problem either with how start should behave, or with the Cats-Effect laws.

@alexandru

This comment has been minimized.

Show comment
Hide comment
@alexandru

alexandru Jul 6, 2018

Member

All the laws in Cats-Effect are fixed in this PR: typelevel/cats-effect#282

One other comment: Task.fromEffect(task.to[IO]) preserves cancelability fails because it doesn't, in fact, preserve cancelability.

This is because the implicit Async[IO] instance is no longer a Concurrent[IO] value 😉

Member

alexandru commented Jul 6, 2018

All the laws in Cats-Effect are fixed in this PR: typelevel/cats-effect#282

One other comment: Task.fromEffect(task.to[IO]) preserves cancelability fails because it doesn't, in fact, preserve cancelability.

This is because the implicit Async[IO] instance is no longer a Concurrent[IO] value 😉

@oleg-py

This comment has been minimized.

Show comment
Hide comment
@oleg-py

oleg-py Jul 31, 2018

Collaborator

Closing this in favor of #686

Collaborator

oleg-py commented Jul 31, 2018

Closing this in favor of #686

@oleg-py oleg-py closed this Jul 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment