New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Iterant.fromReactivePublisher #746

Merged
merged 1 commit into from Oct 17, 2018

Conversation

Projects
None yet
1 participant
@alexandru
Member

alexandru commented Oct 16, 2018

Iterant.fromReactivePublisher has some issues discovered during testing, this PR fixes the tests and some quirks in the implementation that can lead to problems.

@codecov

This comment has been minimized.

codecov bot commented Oct 16, 2018

Codecov Report

Merging #746 into master will increase coverage by 0.05%.
The diff coverage is 82.92%.

@@            Coverage Diff             @@
##           master     #746      +/-   ##
==========================================
+ Coverage   90.41%   90.46%   +0.05%     
==========================================
  Files         401      401              
  Lines       11349    11364      +15     
  Branches     2079     2096      +17     
==========================================
+ Hits        10261    10281      +20     
+ Misses       1088     1083       -5

@alexandru alexandru merged commit 0b3cec7 into monix:master Oct 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment