New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling start/end of Long range in RangeObservable #750

Merged
merged 1 commit into from Oct 24, 2018

Conversation

Projects
None yet
3 participants
@cakper
Contributor

cakper commented Oct 24, 2018

Hello,

I've encountered a problem with RangeObservable that doesn't correctly handle start/end of Long range - current behaviour is that it overflows Long and continues emitting elements.

Problem happens both in Monix 2/3 and would be nice to have it fixed in 2 branch as at the moment I'm using a workaround (use case is that I need to scan whole Long range).

@alexandru

This comment has been minimized.

Member

alexandru commented Oct 24, 2018

👍

@codecov

This comment has been minimized.

codecov bot commented Oct 24, 2018

Codecov Report

Merging #750 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #750      +/-   ##
==========================================
- Coverage    90.4%   90.39%   -0.02%     
==========================================
  Files         401      401              
  Lines       11374    11375       +1     
  Branches     2089     2100      +11     
==========================================
- Hits        10283    10282       -1     
- Misses       1091     1093       +2
@Avasil

Avasil approved these changes Oct 24, 2018

@Avasil

This comment has been minimized.

Collaborator

Avasil commented Oct 24, 2018

Thanks @cakper can you make second PR targeting series/2.x branch?

There is another PR with bugfix for 2.x (#745 ) so we could get both in release

@Avasil Avasil merged commit 860c8b5 into monix:master Oct 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cakper

This comment has been minimized.

Contributor

cakper commented Oct 24, 2018

@Avasil sure, many thanks for the merge. I'll get the other PR ready today :)

@cakper cakper deleted the cakper:observable-range-fix branch Oct 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment