New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic MVar and AsyncVar refactoring #753

Merged
merged 1 commit into from Oct 26, 2018

Conversation

Projects
None yet
1 participant
@alexandru
Member

alexandru commented Oct 25, 2018

Changes:

  • moved MVar into monix.catnap and made it generic, implementing cats.effect.concurrent.MVar.
  • made AsyncVar similar and moved it into the root monix.execution package.

The implementation between them is still shared, this being the virtue of having MVar in Monix — it's here because I want to keep AsyncVar anyway and AsyncVar has no place in Cats.

This, plus I made it use the Concurrent[F] OrElse Async[F] trick.

@codecov

This comment has been minimized.

codecov bot commented Oct 25, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@860c8b5). Click here to learn what that means.
The diff coverage is 82.56%.

@@            Coverage Diff            @@
##             master     #753   +/-   ##
=========================================
  Coverage          ?   90.41%           
=========================================
  Files             ?      405           
  Lines             ?    11482           
  Branches          ?     2112           
=========================================
  Hits              ?    10381           
  Misses            ?     1101           
  Partials          ?        0

@alexandru alexandru merged commit 4f1862c into monix:master Oct 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Avasil Avasil referenced this pull request Oct 30, 2018

Closed

The fate of MVar? #708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment