New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MVar fork on async `take` #756

Merged
merged 1 commit into from Oct 29, 2018

Conversation

Projects
None yet
1 participant
@alexandru
Member

alexandru commented Oct 28, 2018

Related to: typelevel/cats-effect#380

If async take doesn't fork, then its bind continuation can block put indefinitely.

@alexandru alexandru added the bug label Oct 28, 2018

@alexandru alexandru added this to the 3.0.0-RC2 milestone Oct 28, 2018

@codecov

This comment has been minimized.

codecov bot commented Oct 28, 2018

Codecov Report

Merging #756 into master will decrease coverage by 5.31%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##           master     #756      +/-   ##
==========================================
- Coverage   90.39%   85.07%   -5.32%     
==========================================
  Files         405      405              
  Lines       11472    12231     +759     
  Branches     2114     2184      +70     
==========================================
+ Hits        10370    10406      +36     
- Misses       1102     1825     +723

@alexandru alexandru force-pushed the alexandru:mvar-improvement branch from 4c6ddcf to 7963668 Oct 29, 2018

@alexandru alexandru merged commit dfcfb38 into monix:master Oct 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment