New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand FutureLift to take care of CompletableFuture #761

Merged
merged 1 commit into from Nov 2, 2018

Conversation

Projects
None yet
1 participant
@alexandru
Member

alexandru commented Nov 1, 2018

FutureLift is a pretty cool addition to monix-catnap, but it exists basically to convert from Future to cats.effect data types and it would be a pity if it didn't take care of Java's CompletableFuture as well.

Also Task.from can now use FutureLift instances.

Also deprecating the monix-java8 sub-project. This sub-project was created because we wanted to provide support for Scala 2.11 as well, however it's better if this functionality would be merged into FutureLift and FutureUtils. People should just migrate to Scala 2.12 if they want Java 8.

@codecov

This comment has been minimized.

codecov bot commented Nov 2, 2018

Codecov Report

Merging #761 into master will decrease coverage by 0.03%.
The diff coverage is 28.26%.

@@            Coverage Diff             @@
##           master     #761      +/-   ##
==========================================
- Coverage   90.36%   90.32%   -0.04%     
==========================================
  Files         415      416       +1     
  Lines       11774    11768       -6     
  Branches     2149     2136      -13     
==========================================
- Hits        10640    10630      -10     
- Misses       1134     1138       +4

@alexandru alexandru merged commit 9d7505f into monix:master Nov 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment