New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrampolineScheduler — change internal stack to a queue #765

Merged
merged 2 commits into from Nov 6, 2018

Conversation

Projects
None yet
1 participant
@alexandru
Member

alexandru commented Nov 5, 2018

The implementation of TrampolineScheduler changed to use an internal stack, instead of a queue, on top of JavaScript.

This is less than ideal, plus it apparently broke some tests for Outwatch, see: OutWatch/outwatch#242

This PR changes the Trampoline implementation to use a plain queue. We implement our own chunked array queue for performance reasons, because the one in Scala is built via a linked list.


Published test version: 3.0.0-RC2-379831b

alexandru added some commits Nov 5, 2018

@codecov

This comment has been minimized.

codecov bot commented Nov 5, 2018

Codecov Report

Merging #765 into master will increase coverage by 0.08%.
The diff coverage is 96.05%.

@@            Coverage Diff             @@
##           master     #765      +/-   ##
==========================================
+ Coverage   90.34%   90.42%   +0.08%     
==========================================
  Files         418      419       +1     
  Lines       11833    11870      +37     
  Branches     2149     2174      +25     
==========================================
+ Hits        10690    10734      +44     
+ Misses       1143     1136       -7

@alexandru alexandru merged commit 7be5e31 into monix:master Nov 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment