Use globally accessible (rather than local) source paths in JS source maps (#781) #783
@alexandru Please see what you think of this. I have not previously encountered the sbt-git plugin that the Monix build is using. I am also not sure of your versioning policies and preferences, but I have attempted to do something reasonably sensible along the lines of the Cats project as a first attempt at a PR.
I have tested this change (by running
Scenario (1) is probably all that most Monix users will care about, with (2) and (3) being of relevance to Monix developers.
It seems to me that the behaviour in scenario (3) is not ideal – it would probably be better to map to GitHub paths containing the SHA hash of the current commit. However, it is not clear to me whether it is the
Finally, the behaviour of scenario (2) is also debatable. Maybe local paths should be preserved in this situation? Again, though, I’m unsure whether
Thus, I suspect this PR will need further work, and that it would make more sense for a regular Monix contributor to run with that given the policy questions involved. Still, perhaps this PR will be somewhat helpful as a starting point.