Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #780: improve fixed rate scheduling on JS #790

Merged
merged 1 commit into from Dec 10, 2018

Conversation

Projects
None yet
2 participants
@oleg-py
Copy link
Collaborator

commented Dec 5, 2018

This is a simple fix that seems to give most consistency. The idea is basically to add scheduling lag time to task execution time. Test is a bit non-deterministic (and I don't know how Travis would accept these), but change seems to reduce the accumulated error by a factor of magnitude in this simple scenario.

@codecov

This comment has been minimized.

Copy link

commented Dec 5, 2018

Codecov Report

Merging #790 into master will increase coverage by 0.09%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #790      +/-   ##
==========================================
+ Coverage   90.38%   90.48%   +0.09%     
==========================================
  Files         426      426              
  Lines       12308    12308              
  Branches     2264     2264              
==========================================
+ Hits        11125    11137      +12     
+ Misses       1183     1171      -12
@alexandru

This comment has been minimized.

Copy link
Member

commented Dec 10, 2018

It's pretty good.

Another idea would be to have a start time and then schedule at start + period, start + period * 2, start + period * 3 and so on. Not sure how well it works.

Merging.

@alexandru alexandru merged commit 1096549 into monix:master Dec 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.