Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update intervalWithFixedDelay scaladoc #798

Merged
merged 2 commits into from Dec 19, 2018

Conversation

Projects
None yet
2 participants
@Avasil
Copy link
Collaborator

commented Dec 18, 2018

Fixes one mistake and adds new sentence that is also present in intervalAtFixedRate

* (longs) spaced by a given time interval. Starts from 0 with no
* delay, after which it emits incremented numbers spaced by the
* (longs) spaced by a given time interval. Starts from 0 with `initialDelay`,
* after which it emits incremented numbers spaced by the
* `period` of time. The given `period` of time acts as a fixed

This comment has been minimized.

Copy link
@Avasil

Avasil Dec 18, 2018

Author Collaborator

I feel like period should be delay (name of the parameter) but I'm not sure

This comment has been minimized.

Copy link
@alexandru

alexandru Dec 19, 2018

Member

Yes 👍

@codecov

This comment has been minimized.

Copy link

commented Dec 18, 2018

Codecov Report

Merging #798 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #798      +/-   ##
==========================================
- Coverage   85.08%   85.04%   -0.04%     
==========================================
  Files         426      426              
  Lines       13096    13096              
  Branches     2341     2341              
==========================================
- Hits        11143    11138       -5     
- Misses       1953     1958       +5

@Avasil Avasil merged commit 111520c into master Dec 19, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

alexandru added a commit that referenced this pull request Jan 12, 2019

Acquire lock per subscription instead of observable-wide lock (#794)
* Acquire lock per subscription instead of observable-wide lock

* Update cats-effect, cats-effect-laws to 1.1.0 (#788)

* Update sbt-scalajs, scalajs-compiler, scalajs-library... to 0.6.26 (#785)

* Scala 2.12.8 (#797)

* Update intervalWithFixedDelay scaladoc (#798)

* Update intervalWithFixedDelay scaladoc

* Update Observable.scala

* fix scalacOptions (#796)

* fix scalacOptions

"-Ywarn-unused-import" removed since Scala 2.13.x

scala/scala@ad25805

* fix scalacOptions for Scala 2.13.x

some options removed since Scala 2.13.x

* Eagerly null out dequeued elements in ChunkedArrayQueue (#803)

* Observable buffers refactoring (#801)

* Refactoring of Observable buffers and OverflowStrategy

* Observable.create change signature

* Fix Mima reports

* Small adjustments

* Add forgotten default value for maxBatch

* Make OverflowStrategy.Unbounded final

* Fix Mima

* Fix #787: encapsulate local ctx on task execution (#802)

@Avasil Avasil deleted the intervalWithFixedDelay-scaladoc branch Jan 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.