Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observable buffers refactoring #801

merged 8 commits into from Jan 12, 2019


None yet
1 participant
Copy link

commented Dec 27, 2018

  • Fixes #701 by making buffers configured with OverflowStrategy.BackPressure to use a chunk size of min(bufferSize, defaultChunkSize)
  • introduces Platform.recommendedBufferChunkSize, a new global value for setting the recommended chunk size of unbounded buffers, set to 256
  • adds ChannelType.ProducerSide parameters to Observable utils that create buffers (starts from BufferedSubscriber, but also Observable.create, ConcurrentSubject, Pipe)

alexandru added some commits Nov 26, 2018

alexandru added some commits Jan 6, 2019


This comment has been minimized.

Copy link

commented Jan 6, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@1d77551). Click here to learn what that means.
The diff coverage is 71.92%.

@@            Coverage Diff            @@
##             master     #801   +/-   ##
  Coverage          ?   90.46%           
  Files             ?      426           
  Lines             ?    12318           
  Branches          ?     2302           
  Hits              ?    11144           
  Misses            ?     1174           
  Partials          ?        0

@alexandru alexandru changed the title WIP: Observable buffers refactoring Observable buffers refactoring Jan 7, 2019

@alexandru alexandru force-pushed the alexandru:buffers-refactoring-3 branch from 389ad3f to 5ce8258 Jan 10, 2019

alexandru added some commits Jan 10, 2019

@alexandru alexandru merged commit 8868ab1 into monix:master Jan 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed

alexandru added a commit that referenced this pull request Jan 12, 2019

Acquire lock per subscription instead of observable-wide lock (#794)
* Acquire lock per subscription instead of observable-wide lock

* Update cats-effect, cats-effect-laws to 1.1.0 (#788)

* Update sbt-scalajs, scalajs-compiler, scalajs-library... to 0.6.26 (#785)

* Scala 2.12.8 (#797)

* Update intervalWithFixedDelay scaladoc (#798)

* Update intervalWithFixedDelay scaladoc

* Update Observable.scala

* fix scalacOptions (#796)

* fix scalacOptions

"-Ywarn-unused-import" removed since Scala 2.13.x


* fix scalacOptions for Scala 2.13.x

some options removed since Scala 2.13.x

* Eagerly null out dequeued elements in ChunkedArrayQueue (#803)

* Observable buffers refactoring (#801)

* Refactoring of Observable buffers and OverflowStrategy

* Observable.create change signature

* Fix Mima reports

* Small adjustments

* Add forgotten default value for maxBatch

* Make OverflowStrategy.Unbounded final

* Fix Mima

* Fix #787: encapsulate local ctx on task execution (#802)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.