Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #787: encapsulate local ctx on task execution #802

Merged
merged 1 commit into from Jan 12, 2019

Conversation

Projects
None yet
2 participants
@oleg-py
Copy link
Collaborator

commented Dec 30, 2018

I basically redid what was in one of my previous PRs. This ensures Local context is left unchanged when an unsafe method starts executing.

Not entirely sure this fixes all the possible issues (I'm suspicious about .start), but I think it's better than what we currently have.

@oleg-py oleg-py requested a review from alexandru Dec 30, 2018

@codecov

This comment has been minimized.

Copy link

commented Dec 30, 2018

Codecov Report

Merging #802 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #802      +/-   ##
==========================================
+ Coverage   90.42%   90.43%   +<.01%     
==========================================
  Files         426      426              
  Lines       12308    12302       -6     
  Branches     2264     2258       -6     
==========================================
- Hits        11130    11125       -5     
+ Misses       1178     1177       -1
@alexandru

This comment has been minimized.

Copy link
Member

commented Jan 12, 2019

I like it.

@alexandru alexandru merged commit 47500b5 into monix:master Jan 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexandru

This comment has been minimized.

Copy link
Member

commented Jan 12, 2019

Some tests would help, if you have the time.

alexandru added a commit that referenced this pull request Jan 12, 2019

Acquire lock per subscription instead of observable-wide lock (#794)
* Acquire lock per subscription instead of observable-wide lock

* Update cats-effect, cats-effect-laws to 1.1.0 (#788)

* Update sbt-scalajs, scalajs-compiler, scalajs-library... to 0.6.26 (#785)

* Scala 2.12.8 (#797)

* Update intervalWithFixedDelay scaladoc (#798)

* Update intervalWithFixedDelay scaladoc

* Update Observable.scala

* fix scalacOptions (#796)

* fix scalacOptions

"-Ywarn-unused-import" removed since Scala 2.13.x

scala/scala@ad25805

* fix scalacOptions for Scala 2.13.x

some options removed since Scala 2.13.x

* Eagerly null out dequeued elements in ChunkedArrayQueue (#803)

* Observable buffers refactoring (#801)

* Refactoring of Observable buffers and OverflowStrategy

* Observable.create change signature

* Fix Mima reports

* Small adjustments

* Add forgotten default value for maxBatch

* Make OverflowStrategy.Unbounded final

* Fix Mima

* Fix #787: encapsulate local ctx on task execution (#802)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.