Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eagerly null out dequeued elements in ChunkedArrayQueue #803

Merged
merged 1 commit into from Jan 8, 2019

Conversation

Projects
None yet
2 participants
@iravid
Copy link
Contributor

commented Jan 7, 2019

This is a very simplistic fix for an issue I'm having, opening this for discussion (and to avoid keeping this in a local fork :-))

G1 Old Gen before the fix:
image

After the fix:
image

@alexandru

This comment has been minimized.

Copy link
Member

commented Jan 7, 2019

Thanks a lot @iravid for investigating this.

@iravid

This comment has been minimized.

Copy link
Contributor Author

commented Jan 7, 2019

Happy to help! Any chance you could restart the build?

@alexandru

This comment has been minimized.

Copy link
Member

commented Jan 7, 2019

Just did. The build is a little fragile, due to the tests being a little too heavy for Travis.

@codecov

This comment has been minimized.

Copy link

commented Jan 7, 2019

Codecov Report

Merging #803 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #803      +/-   ##
==========================================
+ Coverage   90.42%   90.46%   +0.03%     
==========================================
  Files         426      426              
  Lines       12308    12309       +1     
  Branches     2264     2267       +3     
==========================================
+ Hits        11130    11135       +5     
+ Misses       1178     1174       -4

@alexandru alexandru merged commit 1d77551 into monix:master Jan 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

alexandru added a commit that referenced this pull request Jan 12, 2019

Acquire lock per subscription instead of observable-wide lock (#794)
* Acquire lock per subscription instead of observable-wide lock

* Update cats-effect, cats-effect-laws to 1.1.0 (#788)

* Update sbt-scalajs, scalajs-compiler, scalajs-library... to 0.6.26 (#785)

* Scala 2.12.8 (#797)

* Update intervalWithFixedDelay scaladoc (#798)

* Update intervalWithFixedDelay scaladoc

* Update Observable.scala

* fix scalacOptions (#796)

* fix scalacOptions

"-Ywarn-unused-import" removed since Scala 2.13.x

scala/scala@ad25805

* fix scalacOptions for Scala 2.13.x

some options removed since Scala 2.13.x

* Eagerly null out dequeued elements in ChunkedArrayQueue (#803)

* Observable buffers refactoring (#801)

* Refactoring of Observable buffers and OverflowStrategy

* Observable.create change signature

* Fix Mima reports

* Small adjustments

* Add forgotten default value for maxBatch

* Make OverflowStrategy.Unbounded final

* Fix Mima

* Fix #787: encapsulate local ctx on task execution (#802)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.