Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename keysBuffer to os in groupBy's parameters #805

Merged
merged 1 commit into from Jan 15, 2019

Conversation

Projects
None yet
2 participants
@Avasil
Copy link
Collaborator

commented Jan 12, 2019

keysBuffer suggests that it controls the number of keys but it's not true and can catch users off-guard.

@codecov

This comment has been minimized.

Copy link

commented Jan 12, 2019

Codecov Report

Merging #805 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #805      +/-   ##
==========================================
- Coverage   90.39%   90.34%   -0.05%     
==========================================
  Files         426      426              
  Lines       12323    12323              
  Branches     2273     2273              
==========================================
- Hits        11139    11133       -6     
- Misses       1184     1190       +6

@alexandru alexandru merged commit 2470217 into monix:master Jan 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Avasil Avasil deleted the Avasil:renameGroupByParams branch Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.