Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comments from .jvmopts #827

Merged
merged 1 commit into from Feb 5, 2019

Conversation

Projects
None yet
2 participants
@oleg-py
Copy link
Collaborator

commented Feb 2, 2019

On Windows, if you check out monix and run sbt, you will get Cannot find main class "#" error due to comments in .jvmopts. This caused confusion in my early days when I tried to fix something in monix somewhere back in 2017, and even now I resort to editing the file whilst having git update-index --assume-unchanged done to not accidentally commit it. Also, the link in first comment is broken.

Since other than this, there are no problems working on monix under Windows, I think it's more valuable than a few comments on options :)

Remove comments from .jvmopts
On Windows, if you check out monix and run `sbt`, you will get `Cannot find main class "#"` error due to comments in .jvmopts. This caused confusion in my early days when I tried to fix something in monix somewhere back in 2017, and even now I resort to editing the file whilst having `git update-index --assume-unchanged` done to not accidentally commit it. Also, the link in first comment is broken.

Since other than this, there are no problems working on monix under Windows, I think it's more valuable than a few comments on options :)

@alexandru alexandru merged commit 87d5fb3 into master Feb 5, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.