Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaskLocal should propagate when used with Bracket Methods #839

Merged
merged 1 commit into from Mar 25, 2019

Conversation

Projects
None yet
2 participants
@Avasil
Copy link
Collaborator

commented Mar 9, 2019

Related to #806

Making PR as suggested by @oleg-py

The difference between

Task.unit
    .executeAsync
    .guarantee(local.write(10))

and

Task.unit
    .guarantee(local.write(10))

is that the former starts TaskRestartCallback twice (the first one is just after evaluating guarantee body) and the latter just once.

@alexandru If you could provide some explanation of TaskRestartCallback that would help immensely in putting all the pieces together. :) I feel like I'm getting somewhere with my understanding but there are a lot of guesses at this point

@oleg-py
Copy link
Collaborator

left a comment

I've played a bit with this fix, and it seems to fix a decent number of cases at least. Found #851 as I did though, but it's not bracket-specific.

@Avasil

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 25, 2019

I'm merging then so we can move forward, we will revert it if it turns out to be wrong

@Avasil Avasil merged commit bfd45db into monix:master Mar 25, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Avasil Avasil deleted the Avasil:TaskShift-restoring-locals branch Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.