Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure mapParallelOrdered runs in parallel #846

Merged

Conversation

Projects
None yet
2 participants
@lukestephenson
Copy link
Contributor

commented Mar 12, 2019

See #841

Is there a guarantee with the waiting for the semaphore permit that there will not be multiple permits blocked at once? If so, the ordering might not be guaranteed with this approach.

@lukestephenson lukestephenson force-pushed the lukestephenson:map-parallel-ordered-force-async branch from 5eb771c to a69825a Mar 13, 2019

Luke Stephenson

@lukestephenson lukestephenson force-pushed the lukestephenson:map-parallel-ordered-force-async branch from a69825a to dccb27a Mar 13, 2019

@lukestephenson

This comment has been minimized.

Copy link
Contributor Author

commented Mar 13, 2019

The build is failing with 1 failed test:

monix.execution.internal.AsyncSchedulerSuite
- scheduleWithFixedRate should compensate for scheduling inaccuracy *** FAILED ***
  AssertionException: Error <= 20ms (AsyncSchedulerSuite.scala:108)
    $c_Lminitest_api_AssertionException.$c_jl_Throwable.fillInStackTrace__jl_Throwable(/home/travis/build/monix/monix/monix-execution/js/target/scala-2.12/monix-execution-test-fastopt.js:21093:14)
    $c_Lminitest_api_AssertionException.$c_jl_Throwable.init___T__jl_Throwable__Z__Z(/home/travis/build/monix/monix/monix-execution/js/target/scala-2.12/monix-execution-test-fastopt.js:21201:10)
    minitest.api.AssertionException.<init>(/home/travis/build/monix/monix/monix-execution/js/target/scala-2.12/monix-execution-test-fastopt.js:85046:58)
    {anonymous}()(/home/travis/build/monix/monix/monix-execution/js/target/scala-2.12/monix-execution-test-fastopt.js:48822:63)
    scala.scalajs.runtime.AnonFunction1.apply(/home/travis/build/monix/monix/monix-execution/js/target/scala-2.12/monix-execution-test-fastopt.js:31427:23)
    scala.util.Success.map(/home/travis/build/monix/monix/monix-execution/js/target/scala-2.12/monix-execution-test-fastopt.js:93652:47)
    {anonymous}()(/home/travis/build/monix/monix/monix-execution/js/target/scala-2.12/monix-execution-test-fastopt.js:11065:18)
    scala.scalajs.runtime.AnonFunction1.apply(/home/travis/build/monix/monix/monix-execution/js/target/scala-2.12/monix-execution-test-fastopt.js:31427:23)
    scala.concurrent.impl.Promise.liftedTree1$1(/home/travis/build/monix/monix/monix-execution/js/target/scala-2.12/monix-execution-test-fastopt.js:30532:31)
    {anonymous}()(/home/travis/build/monix/monix/monix-execution/js/target/scala-2.12/monix-execution-test-fastopt.js:30524:22)

I can't see how this is related to the change I made. I've also seen this test failing on other branches (eg https://travis-ci.org/monix/monix/jobs/504177945), so I think the test is flakey

@Avasil

Avasil approved these changes Mar 21, 2019

@Avasil

This comment has been minimized.

Copy link
Collaborator

commented Mar 21, 2019

I'll merge it, would be nice to add test for it so I'll leave #841 open

Thank you once again :)

@Avasil Avasil merged commit af9e61e into monix:master Mar 21, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.