Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix apparently erronous code involving Unit companion #854

Merged
merged 1 commit into from Mar 27, 2019

Conversation

Projects
None yet
3 participants
@SethTisue
Copy link
Contributor

commented Mar 27, 2019

this was caught by the Scala 2.13 community build, the compiler change was by @som-snytt
2.13.0-RC1 will forbid the old code.

[monix] [error] /home/jenkins/workspace/scala-2.13.x-integrate-community-build/target-0.9.16/project-builds/monix-8191d972d6ee8c789100269dc8adc6fabc14b328/monix-execution/shared/src/main/scala/monix/execution/internal/Constants.scala:31:28: `Unit` companion object is not allowed in source; instead, use `()` for the unit value
[monix] [error]   val toUnit = (_: Any) => Unit
[monix] [error]                            ^
[monix] [error] one error found
@Avasil

Avasil approved these changes Mar 27, 2019

Copy link
Collaborator

left a comment

Thanks @SethTisue I will merge it when CI passes

@Avasil Avasil merged commit 2428f22 into monix:master Mar 27, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@SethTisue SethTisue deleted the SethTisue:small-2.13-fix branch Mar 27, 2019

@som-snytt

This comment has been minimized.

Copy link

commented Mar 28, 2019

To maximize the pun:

val `to()` = (_: Any) => ()

I assume I was summoned for pun patrol?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.