Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add observable take while inclusive #872

Merged
merged 1 commit into from May 16, 2019

Conversation

Projects
None yet
3 participants
@allantl
Copy link
Contributor

commented Apr 26, 2019

Resolve #871

@oleg-py

This comment has been minimized.

Copy link
Collaborator

commented Apr 27, 2019

Can you also do it for a dropWhile?

@allantl allantl force-pushed the allantl:takewhile-inclusive branch from 6611d23 to 9f7b623 Apr 29, 2019

@allantl

This comment has been minimized.

Copy link
Contributor Author

commented Apr 29, 2019

@oleg-py Sure, done!

@oleg-py

This comment has been minimized.

Copy link
Collaborator

commented May 13, 2019

@allantl sorry for super slow responses. You need to add MiMa exclusions to build.sbt - it's fine to exclude anything in internal subpackage.

@allantl allantl force-pushed the allantl:takewhile-inclusive branch from 9f7b623 to e0c765f May 16, 2019

@allantl allantl force-pushed the allantl:takewhile-inclusive branch from e0c765f to 3bce4bf May 16, 2019

@allantl

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

@oleg-py No worries, I added the MiMa exclusions

@oleg-py
Copy link
Collaborator

left a comment

Ok, looks good to me 👍

@Avasil

Avasil approved these changes May 16, 2019

Copy link
Collaborator

left a comment

Merging then. :)

Thanks for the contribution!

@Avasil Avasil merged commit 407eced into monix:master May 16, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.