Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 2.13.0 Cats-Effect 2.0.0-RC1 #875

Merged
merged 37 commits into from Sep 10, 2019

Conversation

@Avasil
Copy link
Collaborator

commented May 2, 2019

Related to #862

@alexandru @oleg-py We have to figure out whether our next release is on top of cats-effect 2.0.0-M1 and/or 1.3.0. I think there are some binary incompatibilities in cats-effect 2.0

@Avasil Avasil referenced this pull request May 2, 2019
Avasil added 5 commits May 2, 2019
Merge branch 'master' into cats-effect-2.0.0-M1-scala2.13
# Conflicts:
#	monix-reactive/shared/src/main/scala/monix/reactive/Observable.scala
@oleg-py

This comment has been minimized.

Copy link
Collaborator

commented May 13, 2019

I think there are some binary incompatibilities in cats-effect 2.0

IIRC cats-effect 2.0 is binary compatible with 1.x on Scala 2.12, same as cats.

3.0 final will be on cats-effect 2.0, but we can roll RC3 with fixed locals for CE 1.x if CE 2.0 isn't yet final by that time.

Avasil added 3 commits Jun 1, 2019

@Avasil Avasil changed the title Scala 2.13-RC1, Cats-Effect 2.0.0-M1 Scala 2.13.0 Cats-Effect 2.0.0-M4 Jun 20, 2019

Avasil added 3 commits Jun 20, 2019
@xuwei-k

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2019

Any updates? 👀

@Avasil

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 1, 2019

@xuwei-k I don't know why CI fails but we will probably wait with release for stable Cats-Effect support if we use 2.0 for Monix 3.0 (or 3.1)

Would it be helpful to release a snapshot version from this branch?

@niebloomj

This comment has been minimized.

Copy link

commented Jul 23, 2019

Any updates?

@Avasil

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 23, 2019

@niebloomj I have a snapshot from this branch if you're interested: 3.0.0-eddc79d-SNAPSHOT

I'm not sure when stable Cats-Effect supporting 2.13 is released and I don't want to release on a milestone

@Avasil Avasil changed the title Scala 2.13.0 Cats-Effect 2.0.0-M4 Scala 2.13.0 Cats-Effect 2.0.0-RC1 Aug 8, 2019

@BalmungSan BalmungSan referenced this pull request Aug 30, 2019
6 of 6 tasks complete
Avasil added 2 commits Sep 3, 2019
@@ -2,6 +2,16 @@ import com.typesafe.tools.mima.core.ProblemFilters.exclude
import com.typesafe.tools.mima.core._

object MimaFilters {
lazy val changesFor_3_0_0__RC5: Seq[ProblemFilter] = Seq(
// Incompatible signatures should not cause linking problems.

This comment has been minimized.

Copy link
@Avasil

Avasil Sep 3, 2019

Author Collaborator

Should be fine but we might want to repeat this test: typelevel/cats-effect#609 (review)

This comment has been minimized.

Copy link
@alexandru

alexandru Sep 9, 2019

Member

Are we sure they don't cause linking problems?

What happened there?

This comment has been minimized.

Copy link
@alexandru

alexandru Sep 9, 2019

Member

Oh, it's due to the changed Parallel from Cats or something?

This comment has been minimized.

Copy link
@alexandru

alexandru Sep 9, 2019

Member

If so, then there's nothing we can do there.

@alexandru

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

@Avasil see my PR: Avasil#4

Avasil added 4 commits Sep 9, 2019
@alexandru

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

The tests are now failing due to Mima, since we never published packages for 2.13.0.

@alexandru

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

We should only run Mima for the lowest version supported, in this case 2.11 and not for 2.13.

Avasil and others added 2 commits Sep 9, 2019

@alexandru alexandru merged commit 987fe24 into monix:master Sep 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.