Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Issue-931】Remove try-catch for EvalOnceObservable implementation #932

Merged
merged 1 commit into from Jun 27, 2019

Conversation

@TapanVaishnav
Copy link
Contributor

commented Jun 27, 2019

#931

As written in the issue description, Observable need not to throw any exceptions as per contract so I have removed the try-catch and simply made a sequential calling for the desired processing.

I have also added one relevant test.

@Avasil
Avasil approved these changes Jun 27, 2019
Copy link
Collaborator

left a comment

Many thanks for the contribution!

@Avasil Avasil merged commit 38a7a71 into monix:master Jun 27, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.