Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flatmap combinators #933

Merged
merged 6 commits into from Jul 18, 2019

Conversation

@valenterry
Copy link
Contributor

commented Jun 27, 2019

Closes #929

@valenterry valenterry changed the title Valenterry add flatmap combinators Add flatmap combinators Jun 27, 2019

@Avasil
Avasil approved these changes Jun 27, 2019
Copy link
Collaborator

left a comment

It would be nice to have a small example in scaladocs (like a print + return value)

Many thanks for the PR! :D

@valenterry

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2019

It would be nice to have a small example in scaladocs (like a print + return value)

Added examples 👍

valenterry added 2 commits Jun 27, 2019
@alexandru

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

Hey guys, see my comments on: #935

@valenterry

This comment has been minimized.

Copy link
Contributor Author

commented Jul 15, 2019

@Avasil @alexandru changed it accordingly to #935, please re-review

@Avasil
Avasil approved these changes Jul 15, 2019

@Avasil Avasil merged commit 5bbe8cd into monix:master Jul 18, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.