Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collectWhile observable #945

Merged
merged 1 commit into from Jul 11, 2019

Conversation

@allantl
Copy link
Contributor

commented Jul 7, 2019

Closes #925

@allantl allantl closed this Jul 7, 2019

@allantl allantl reopened this Jul 7, 2019

@Avasil

This comment has been minimized.

Copy link
Collaborator

commented Jul 9, 2019

Thank you @allantl !
Looks great but would you mind adding 1 test to make sure it completes early? e.g. equivalence to takeWhile + collect with property based test, similar to Iterant tests

@allantl allantl force-pushed the allantl:feature/collect-while-observable branch from eb18ddf to e0408d1 Jul 11, 2019

@allantl allantl closed this Jul 11, 2019

@allantl allantl reopened this Jul 11, 2019

@allantl

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2019

@Avasil Sure, its done

@Avasil
Avasil approved these changes Jul 11, 2019
Copy link
Collaborator

left a comment

Thanks, I'll merge when CI passes

@Avasil Avasil merged commit 6a732d6 into monix:master Jul 11, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.