Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add void to Task + Coeval #951

Merged
merged 1 commit into from Jul 18, 2019

Conversation

@allantl
Copy link
Contributor

commented Jul 13, 2019

I know we have this in cats. But its pretty annoying having to import just for void.

@allantl allantl closed this Jul 13, 2019

@allantl allantl reopened this Jul 13, 2019

@Avasil
Avasil approved these changes Jul 15, 2019
Copy link
Collaborator

left a comment

Thank you!
I'm also using it quite often so I'm okay with adding it

@oleg-py
Copy link
Collaborator

left a comment

Can you add it for Coeval too? I'd like to have the two consistent where possible (all non-async stuff)

@allantl allantl force-pushed the allantl:feature/task-void branch from 259c64c to e364607 Jul 17, 2019

@allantl allantl changed the title Add void to Task Add void to Task + Coeval Jul 17, 2019

@allantl

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2019

Done! Please take a look again.

@Avasil Avasil merged commit f297300 into monix:master Jul 18, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.