Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ContextShift.evalOn in terms of Task.executeOn #952

Merged
merged 3 commits into from Jul 19, 2019

Conversation

@Avasil
Copy link
Collaborator

commented Jul 18, 2019

Following suggestion from @oleg-py
Should be a bit safer considering Monix's auto-shifts

@Avasil Avasil requested review from alexandru and oleg-py Jul 18, 2019

@oleg-py
Copy link
Collaborator

left a comment

I think we should add a test that would've failed with previous behavior, e.g. "inside evalOn, both before after Task.shift, Task.deferAction has s2 as its scheduler".

@Avasil Avasil merged commit ba3fbe9 into monix:master Jul 19, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Avasil Avasil deleted the Avasil:ContextShift.evalOn-executeOn branch Aug 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.