Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make default scheduler remove cancelled tasks #953

Merged
merged 1 commit into from Jul 19, 2019

Conversation

@Avasil
Copy link
Collaborator

commented Jul 18, 2019

Fixes #912

By extension it will also set this policy in many other builders.

@Avasil Avasil requested review from alexandru and oleg-py Jul 18, 2019

)
lazy val scheduledExecutor: ScheduledExecutorService = {
val tp = new ScheduledThreadPoolExecutor(
1,

This comment has been minimized.

Copy link
@Avasil

Avasil Jul 18, 2019

Author Collaborator

Cats-Effect uses 2 threads, not sure what's the reasoning behind this

@oleg-py
Copy link
Collaborator

left a comment

2 threads were there in cats-effect from the start, not sure why @alexandru made it this way.

@Avasil Avasil merged commit 853290d into monix:master Jul 19, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexandru

This comment has been minimized.

Copy link
Member

commented Jul 27, 2019

@oleg-py @Avasil no specific reason.

IMO the important thing is to ensure that scheduled tasks don't get executed on that scheduler.
We could use 2 threads as well.

@Avasil Avasil deleted the Avasil:scheduler-set-remove-onCancel branch Aug 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.