Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename `Task.forkAndForget` to `Task.startAndForget` #972

Merged
merged 6 commits into from Aug 5, 2019

Conversation

@Avasil
Copy link
Collaborator

commented Aug 2, 2019

Fixes #877

@@ -2425,6 +2425,20 @@ sealed abstract class Task[+A] extends Serializable {
*/
final def void: Task[Unit] =
this.map(_ => ())

// Deprecation directly in `Task` to avoid binary breakage just before the release

This comment has been minimized.

Copy link
@Avasil

Avasil Aug 2, 2019

Author Collaborator

I was getting DirectMissingMethodProblem if I put it in Deprecations syntax so wanted to be safe

@alexandru

This comment has been minimized.

Copy link
Member

commented Aug 3, 2019

👍

@alexandru

This comment has been minimized.

Copy link
Member

commented Aug 3, 2019

@Avasil from a code organization perspective, I don't like leaving @deprecated methods on the classes themselves.

One idea would be to create a new trait for deprecated methods in the TaskDeprecated object and put this method there.

Avasil added 2 commits Aug 4, 2019
@Avasil

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 4, 2019

@alexandru 👍

@Avasil Avasil merged commit 009c434 into monix:master Aug 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Avasil Avasil deleted the Avasil:issue-877-task-start-and-forget branch Aug 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.