Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #991: Local and TaskRunLoop #993

Merged
merged 5 commits into from Aug 29, 2019

Conversation

@alexandru
Copy link
Member

commented Aug 27, 2019

See #991 for details.

alexandru added 2 commits Aug 27, 2019
@alexandru

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2019

Released hash version for testing: 3.0.0-RC4-99273a4

@alexandru alexandru changed the title [WIP] Fix #991: Local and TaskRunLoop Fix #991: Local and TaskRunLoop Aug 28, 2019

@@ -212,9 +212,17 @@ private[eval] object TaskRunLoop {
context.frameRef.reset()

// Transporting the current context if localContextPropagation == true.
Local.bind(savedLocals) {
var prevLocals: Local.Context = null
if (savedLocals != null) {

This comment has been minimized.

Copy link
@Avasil

Avasil Aug 28, 2019

Collaborator

Is it needed if there is already a null check in Local.bind? Or is it just to inline?

This comment has been minimized.

Copy link
@alexandru

alexandru Aug 29, 2019

Author Member

I'm doing this for inlining, since Local.bind is no longer a macro and I don't want to have the penalty of that call in case locals are not enabled.

@Avasil
Avasil approved these changes Aug 29, 2019

@alexandru alexandru merged commit 1917be4 into monix:master Aug 29, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.