Add warnings pragma to main module #10

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@paultcochrane

Using the warnings pragma is considered good practice (as mentioned in
Perl Best Practices) and is one of the extra kwalitee
metrics
. Adding the
warnings pragma produced no warnings when the test suite was run, so its
addition shouldn't cause any problems for the module. Adding the pragma
thus also addresses the use_warnings issue mentioned on CPANTS.

This PR is submitted in the hope that it is helpful. If it needs to be changed in any way, please just let me know and I'll update it and resubmit.

Add warnings pragma to main module
Using the `warnings` pragma is considered good practice (as mentioned in
Perl Best Practices) and is one of the [extra kwalitee
metrics](http://cpants.cpanauthors.org/dist/Crypt-OpenSSL-RSA).  Adding the
`warnings` pragma produced no warnings when the test suite was run, so its
addition shouldn't cause any problems for the module.  Adding the pragma
thus also addresses the `use_warnings` issue mentioned on CPANTS.
@toddr

This comment has been minimized.

Show comment
Hide comment
@toddr

toddr Apr 14, 2018

Sorry I had done this before I saw this PR. toddr@885fe6e

ok to close.

toddr commented Apr 14, 2018

Sorry I had done this before I saw this PR. toddr@885fe6e

ok to close.

@paultcochrane paultcochrane deleted the paultcochrane:pr/add-warnings-pragma branch Apr 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment