New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls plugin is loading files in current directory if no absolute path is given #225

Closed
J-Siu opened this Issue Dec 12, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@J-Siu

J-Siu commented Dec 12, 2015

According to tls.conf comment:

[TLS]
    # If no absolute path is given, files are assumed to be located
    # in plugin configuration directory. All files are assumed to be
    # stored in PEM format.

However if no absolute path is given, the plugin is trying to load files in current directory.

PS: Tested with "./configure --local --enable-plugins=tls --mbedtls-shared"

edsiper added a commit that referenced this issue Dec 12, 2015

Plugins: TLS: fix configuration loader for relative paths (Fix #225)
The TLS plugin configuration allows to load the certificates and keys
from absolute or relative paths, the relative discovery process was broken.

This patch fixes the usage of relative paths for certificates.

Signed-off-by: Eduardo Silva <eduardo@monkey.io>
@edsiper

This comment has been minimized.

Show comment
Hide comment
@edsiper

edsiper Dec 12, 2015

Member

Thanks for reporting this. I just applied a fix for this problem:

9d996eb

Member

edsiper commented Dec 12, 2015

Thanks for reporting this. I just applied a fix for this problem:

9d996eb

@edsiper edsiper closed this Dec 12, 2015

edsiper added a commit that referenced this issue Dec 12, 2015

Plugins: TLS: fix configuration loader for relative paths (Fix #225)
The TLS plugin configuration allows to load the certificates and keys
from absolute or relative paths, the relative discovery process was broken.

This patch fixes the usage of relative paths for certificates.

Signed-off-by: Eduardo Silva <eduardo@monkey.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment