fix: save confidence mode after setting stopOnError and vice versa#4667
Merged
Conversation
Contributor
Author
|
Hi @Miodec config.confidenceMode = cm;
if (config.confidenceMode !== "off") {
config.freedomMode = false;
config.stopOnError = "off";
saveToLocalStorage("stopOnError", nosave);
}
saveToLocalStorage("confidenceMode", nosave);I think, in any of set functions, if the condition is true, you have to save all of what you are trying to reset? |
Member
Not sure what you mean here, PR is good though |
Contributor
Author
In the code I attached above, |
Member
|
Yeah, ideally we should save everything that we change. |
Contributor
Author
|
Good, shall I save them on this PR? |
Member
|
Yeah |
Contributor
Author
|
@Miodec You can merge now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Saving config to localStorage after resetting some values.
Closes #4638