Fix/missing project list #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monkut
requested changes
Aug 20, 2018
ghorgs/wrappers.py
Outdated
| all_data.extend(data) | ||
|
|
||
| # Archie> Need to add this check here so last page will be processed | ||
| # Archie> Need to move this check here so last page will be processed for project |
Owner
There was a problem hiding this comment.
Can you remove your name here from this comment.
We know since who left it do to the commit history. ;)
Contributor
Author
There was a problem hiding this comment.
Oops sorry that was my personal comment during debugging :P
Contributor
Author
|
Cleaned the comment without name, please check. |
monkut
approved these changes
Aug 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added back the else statement on line 56, without it the while loop ran endlessly for non "project" url because 'Link' header is not there.