From da3e41cf999fb5775ce0a988d75118b8ce3403ee Mon Sep 17 00:00:00 2001 From: monkut Date: Fri, 31 Aug 2018 18:08:36 +0900 Subject: [PATCH] fixing bug in add_colums creation. Aligning to accept a list of column names for creation. (Was passing a list of column names, but expected dict internally) --- ghorgs/__init__.py | 2 +- ghorgs/managers.py | 14 +++++++------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/ghorgs/__init__.py b/ghorgs/__init__.py index d93b5b2..a6587ae 100644 --- a/ghorgs/__init__.py +++ b/ghorgs/__init__.py @@ -1 +1 @@ -__version__ = '0.2.3' +__version__ = '0.2.4' diff --git a/ghorgs/managers.py b/ghorgs/managers.py index b0c4ab5..431c589 100644 --- a/ghorgs/managers.py +++ b/ghorgs/managers.py @@ -6,7 +6,7 @@ import json import uuid import logging -from typing import Tuple, List, Generator +from typing import Tuple, List, Generator, Optional from functools import lru_cache import requests @@ -60,7 +60,7 @@ def _get_owner_id(self, name: str) -> str: raise UnexpectedResponseError(e.args) return org_id - def create_organizational_project(self, name: str, description: str, columns: list =None) -> Tuple[str, List[object]]: + def create_organizational_project(self, name: str, description: str, columns: Optional[list]=None) -> Tuple[str, List[object]]: """ Create an Organizational Project in github @@ -74,8 +74,8 @@ def create_organizational_project(self, name: str, description: str, columns: li .. code:: python [ - {'name': COLUMN_NAME}, - {'name': COLUMN_NAME}, + COLUMN_NAME, + COLUMN_NAME ] :return: @@ -131,7 +131,7 @@ def create_organizational_project(self, name: str, description: str, columns: li return project_url, responses - def add_columns(self, project_id: str, columns: List[dict]) -> List: + def add_columns(self, project_id: str, columns: List[str]) -> List: """ Add column(s) to the given project. @@ -144,7 +144,7 @@ def add_columns(self, project_id: str, columns: List[dict]) -> List: """ addcolumns_responses = [] - for column_definition in columns: + for column_name in columns: mutation_id = str(uuid.uuid4()) # get a random id graphql_addprojectcolumn = """ mutation { @@ -157,7 +157,7 @@ def add_columns(self, project_id: str, columns: List[dict]) -> List: } } } - }""" % {'name': column_definition['name'], + }""" % {'name': column_name, 'project_id': project_id, 'mutation_id': mutation_id}