Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphicsDevice.DrawInstancedPrimitives API not yet implemented in GL. #913

Closed
CartBlanche opened this issue Oct 29, 2012 · 7 comments · Fixed by #4920
Closed

GraphicsDevice.DrawInstancedPrimitives API not yet implemented in GL. #913

CartBlanche opened this issue Oct 29, 2012 · 7 comments · Fixed by #4920
Labels
Help Wanted OpenGL OpenGL graphics backend
Milestone

Comments

@CartBlanche
Copy link
Contributor

As Per subject line. Just adding this here so we know it needs implementing.

@tinco
Copy link

tinco commented Sep 7, 2013

+1 for this feature :)

@tomspilman
Copy link
Member

This would be good to see implemented soon.

@MoonStorm
Copy link

Since Tom nicely decided to do some spring cleaning, is there any chance of having a look again at:

#2047
and
#1767

I'm sure the good people put effort into writing the code in those pull requests.

@tomspilman
Copy link
Member

is there any chance of having a look again at:

We will get those features in there, but those PRs are closed. They would need to be resubmitted with all the conflicts resolved and the issues that were brought up attended to.

I'm sure the good people put effort into
writing the code in those pull requests.

I really hate having to reject a PR... the other core developers do as well. This is largely why so many have piled up in the last year. We cannot simply merge anything given to us.... good intentions and effort are just not part of the criteria we can consider.

It has become apparent to me that someone needs to be the bad guy here and make some of the hard choices to close stuff. I hope that doesn't discourage people from contributing, but we can't sustain the current state of things either.

@gruntbatch
Copy link

Out of curiosity, should this issue be marked as closed? It looks like #4195 may have solved both this issue and #914

@mgarstenauer
Copy link
Contributor

#4195 only provides the DirectX implementation. OpenGL implementation is still missing.
(--> We can remove the DirectX label.)

@tomspilman tomspilman removed the DirectX DirectX graphics backend label Feb 21, 2016
@tomspilman
Copy link
Member

@mgarstenauer - Done and edited the title.

@tomspilman tomspilman changed the title GraphicsDevice.DrawInstancedPrimitives API not yet implemented. GraphicsDevice.DrawInstancedPrimitives API not yet implemented in GL. Feb 21, 2016
@tomspilman tomspilman added this to the 3.6 Release milestone Mar 16, 2016
@tomspilman tomspilman modified the milestones: 3.6 Release, 3.7 Release Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted OpenGL OpenGL graphics backend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants