Skip to content

BeginShowKeyboardInput fixed for iOS #2260

Merged
merged 5 commits into from Apr 10, 2014

5 participants

@Nezz
Nezz commented Mar 6, 2014

Keyboard input wasn't really working, so I rewrote it. This PR fixes #1689. The new code is much cleaner.

I have also included the hiding of the status bar on iOS 7.

@mgbot
mgbot commented Mar 6, 2014

Test FAILed.
Refer to this link for build results: http://build.monogame.net/job/PullRequestTester/609/

@Nezz
Nezz commented Mar 6, 2014

The build has failed because the build bot doesn't seem to have XCode 5.0. Without its support for iOS7, there is no PrefersStatusBarHidden method to override.

@totallyeviljake

is there a way to check if you are targeting IOS7 and ifdef this code?

@Nezz
Nezz commented Mar 6, 2014

Sadly it is not possible. When iOS 6 came and broke the autorotation, we had to add some method overrides similar to this.
Since this is a seperate problem from the keyboard, should I separate it into a second PR?

@KonajuGames

All iOS apps submitted to the App Store must now be built with the iOS 7 SDK, so this is one reason to update Xcode and the iOS SDK on the build bot. The app can still target iOS 6, but it must be built with the iOS 7 SDK. Will the addition of PreferStatusBarHidden break if the dev sets iOS 6 as a target and runs on a iOS 6 device?

Hiding the status bar should only be done if the dev has set GraphicsDeviceManager.IsFullScreen to true. Otherwise they want it visible.

@Nezz
Nezz commented Mar 7, 2014

Removed the status bar part from this PR so it can be discussed further in #2265 and we can merge this PR.

@mgbot
mgbot commented Mar 7, 2014

Test PASSed.
Refer to this link for build results: http://build.monogame.net/job/PullRequestTester/618/

@azchohfi

This also fixes the Guide.IsVisible not being set to false at the end of the process.
This needs to be updated to work with protobuild.

@Nezz
Nezz commented Mar 27, 2014

Update complete to work with protobuild.

@mgbot
mgbot commented Mar 27, 2014

Test PASSed.
Refer to this link for build results: http://build.monogame.net/job/PullRequestTester/661/

@Nezz
Nezz commented Apr 7, 2014

Can we go on with the merge?

@azchohfi
azchohfi commented Apr 8, 2014

Please, do.

@KonajuGames KonajuGames merged commit a5dc465 into mono:develop Apr 10, 2014

1 check passed

Details default Merged build finished.
@KonajuGames

Merged.

@Nezz Nezz deleted the Nezz:ioskeyboardfix branch Apr 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.