Model docs & fixes(remake) #3768
Conversation
|
@tomspilman Accept ? |
| { | ||
|
|
||
| } | ||
|
|
||
| public Model(GraphicsDevice graphicsDevice, List<ModelBone> bones, List<ModelMesh> meshes) | ||
| internal Model(GraphicsDevice graphicsDevice, List<ModelBone> bones, List<ModelMesh> meshes) |
There was a problem hiding this comment.
I think it is worth keeping this API public. There is really nothing that needs to be private or hidden here.
There was a problem hiding this comment.
In XNA there is no public constructor for Model. I really doubt that someone needs to construct it manually from parts. These constuctors in general used only by content pipeline.
There was a problem hiding this comment.
I am fully aware of how they are generally used and that it isn't public in XNA. There is zero harm in making this public anyway and allows someone to build a model from code which is reasonable in some cases.
There was a problem hiding this comment.
Ok, than I open it and adds docs..
There was a problem hiding this comment.
(after test) Yes this constructor works and you can really build model from code.
|
@tomspilman Accept ? |
|
@tomspilman Recheck pls |
|
Ok... i'm good with this. Merging! |
remake of #3738