Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style: Improve SKRegion.cs style consistency and add style configuration file for OmniSharp #795

Open
wants to merge 2 commits into
base: master
from

Conversation

@vexx32
Copy link
Contributor

commented Feb 22, 2019

  1. Adds a new omnisharp.json file to the repo to allow users operating in VS Code to easily follow the style guidelines laid out in the documentation on the repo.
    • If there's anything here that needs modifying, please let me know, but I have made every effort to tailor the configuration to the assigned style guide.
  2. I was just recently working in SKRegion.cs in #788 so I tidied up while I was there, and moved the style changes to this PR as it's more appropriate to do style changes separately to functionality.

Hopefully with the new style configuration file, contributors who prefer to use VS Code will find it much easier to follow the assigned style guide -- at least for myself, it's a very unfamiliar style when working with C#, but I suppose I'm liable to be more unusual in that respect as I've mostly worked in the PowerShell Core repo.

@mikekinsman

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2019

OPS Build status updates of commit 40006e0:

🕙 Preparing: average preparing time is 1 min(s) 58 sec(s)

@mikekinsman

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2019

OPS Build status updates of commit 40006e0:

🕙 Incremental building: average incremental building time is 19 sec(s)

@mikekinsman

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2019

OPS Build status updates of commit 40006e0:

Validation status: passed

File Status Preview URL Details
binding/Binding/SKRegion.cs Succeeded
omnisharp.json Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.