tests: fix build #7

Merged
merged 1 commit into from Aug 2, 2013

Projects

None yet

4 participants

@knocte
Contributor
knocte commented Jul 9, 2013

Build was failing this way:

/bin/bash ../libtool --tag=CC --mode=link gcc -g -O2 -pthread -o testgdi testgdi.o ../src/libgdiplus.la -lpthread -lfontconfig
libtool: link: gcc -g -O2 -pthread -o .libs/testgdi testgdi.o ../src/.libs/libgdiplus.so -lpthread -lfontconfig -pthread
/usr/bin/ld: testgdi.o: undefined reference to symbol 'g_print'
/usr/bin/ld: note: 'g_print' is defined in DSO /lib/x86_64-linux-gnu/libglib-2.0.so.0 so try adding it to the linker command line
/lib/x86_64-linux-gnu/libglib-2.0.so.0: could not read symbols: Invalid operation
collect2: error: ld returned 1 exit status
make[2]: *** [testgdi] Error 1
make[2]: Leaving directory /home/knocte/Documents/Code/libgdiplus/tests' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory/home/knocte/Documents/Code/libgdiplus'
make: *** [all] Error 2

@jstedfast
Member

Instead of setting LIBS directly with -lpthread -lglib-2.0 ... shouldn't it be fixed to be substituted by configure.ac by doing a pkg-config --libs check?

@knocte knocte tests: fix build
Build was failing this way:

/bin/bash ../libtool --tag=CC   --mode=link gcc  -g -O2 -pthread   -o testgdi testgdi.o ../src/libgdiplus.la -lpthread -lfontconfig
libtool: link: gcc -g -O2 -pthread -o .libs/testgdi testgdi.o  ../src/.libs/libgdiplus.so -lpthread -lfontconfig -pthread
/usr/bin/ld: testgdi.o: undefined reference to symbol 'g_print'
/usr/bin/ld: note: 'g_print' is defined in DSO /lib/x86_64-linux-gnu/libglib-2.0.so.0 so try adding it to the linker command line
/lib/x86_64-linux-gnu/libglib-2.0.so.0: could not read symbols: Invalid operation
collect2: error: ld returned 1 exit status
make[2]: *** [testgdi] Error 1
make[2]: Leaving directory `/home/knocte/Documents/Code/libgdiplus/tests'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/knocte/Documents/Code/libgdiplus'
make: *** [all] Error 2
1fa831c
@knocte
Contributor
knocte commented Jul 18, 2013

True! commit amended, pushed (pull request updated)

@knocte
Contributor
knocte commented Jul 29, 2013

@jstedfast ping?

@suhrab
suhrab commented Jul 31, 2013

knocte's fix works

@bfreshour

Thank you for this fix. Worked for me.

@jstedfast jstedfast merged commit de61618 into mono:master Aug 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment