Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Treat the Timedout state as the Issues state wrt notifications.

  • Loading branch information...
commit 84632a7ff7d65e867583fe7c4af21967a69fd69e 1 parent 69723e2
@rolfbjarne rolfbjarne authored
Showing with 4 additions and 4 deletions.
  1. +4 −4 MonkeyWrench.Web.WebService/Notifications.cs
View
8 MonkeyWrench.Web.WebService/Notifications.cs
@@ -104,7 +104,7 @@ public static void Notify (DBWork work, DBRevisionWork revision_work)
if (notifications == null)
return;
- if (!(work.State == DBState.Failed || work.State == DBState.Issues))
+ if (!(work.State == DBState.Failed || work.State == DBState.Issues || work.State == DBState.Timeout))
return;
ThreadPool.QueueUserWorkItem ((v) => ProcessNotify (work, revision_work));
@@ -151,7 +151,7 @@ private bool Evaluate (DBWork work, DBRevisionWork revision_work, out bool nonfa
if (work.State == DBState.Success)
return false;
- if (work.State == DBState.Issues && Notification.Type == DBNotificationType.FatalFailuresOnly)
+ if ((work.State == DBState.Issues || work.State == DBState.Timeout) && Notification.Type == DBNotificationType.FatalFailuresOnly)
return false;
/* We need to see if there are any successfull builds later than this one */
@@ -204,13 +204,13 @@ private bool Evaluate (DBWork work, DBRevisionWork revision_work, out bool nonfa
switch (Notification.Type) {
case DBNotificationType.AllFailures:
- return work.State == DBState.Issues || work.State == DBState.Failed;
+ return work.State == DBState.Issues || work.State == DBState.Failed || work.State == DBState.Timeout;
case DBNotificationType.FatalFailuresOnly:
if (nonfatal)
return false;
return work.State == DBState.Failed && newest_state == DBState.Failed;
case DBNotificationType.NonFatalFailuresOnly:
- return work.State == DBState.Issues || nonfatal;
+ return (work.State == DBState.Issues || work.State == DBState.Timeout) || nonfatal;
default:
return false;
}
Please sign in to comment.
Something went wrong with that request. Please try again.