New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a GTK#3 Gui project #8

Merged
merged 36 commits into from Nov 4, 2014

Conversation

Projects
None yet
4 participants
@robpvn
Contributor

robpvn commented Oct 12, 2013

This PR adds a new subproject named Mono.Addins.GuiGtk3, which is simply the Gui subproject ported to GTK#3. This is done as part of the #monohack 2013 hackfest effort to port apps to GTK#3, as many of the apps depend on Mono.Addins.Gui. Basically they can now pull in GuiGtk3 instead of Gui, and the API will be identical. (While those using GTK#2 can continue doing so...)

The add-in UI is slightly less pretty than the original and could use a fair bit of polish, but it should be fully functional. There has also been added a Tests project that uses GuiGtk3 to open a GUI for testing purposes.

The makefile setup is altered to allow conditional building of GTK#3 support, which defaults to off since it is not so common yet.

robpvn added some commits Oct 10, 2013

Add the DebugGTK3 type of configuration to sln
Not added it to csproj, since MD seems to be wiping my changes
Made Conditional references in csproj file
Some requirements: Need to set MonoDevelop to build with xBuild (or use makefile to build)
In Monodevelop, due to a bug, all references will appear twice.
Add new GTK UI project
Currently have stubs for all UI elements, but not connected up
Wire in infoView button clicks
Just need their dialogues to come up now...
Make refresh progress dialog show up!
Needs to be tested in the field so that we can see if it actually
updates the progressbar etc.
Revert "Revert "Add Conditional check for GTK3""
This reverts commit 0aa5fb5, because I discovered
that I had reverted one commit too many. Slightly embarrassing, but at least git
lets me fix it!
@robpvn

This comment has been minimized.

Show comment
Hide comment
@robpvn

robpvn Oct 14, 2013

Contributor

Belay that! Just discovered that I screwed something up in the makefiles so that a clean checkout won't build. (forgot to do a make distclean) At the airport right now, can't fix until in a day or three.

Contributor

robpvn commented Oct 14, 2013

Belay that! Just discovered that I screwed something up in the makefiles so that a clean checkout won't build. (forgot to do a make distclean) At the airport right now, can't fix until in a day or three.

@robpvn

This comment has been minimized.

Show comment
Hide comment
@robpvn

robpvn Oct 16, 2013

Contributor

OK, now I've fixed it so that it will work on a clean checkout! 🚢

Contributor

robpvn commented Oct 16, 2013

OK, now I've fixed it so that it will work on a clean checkout! 🚢

@j-4

This comment has been minimized.

Show comment
Hide comment
@j-4

j-4 Nov 20, 2013

I don't want to be rude, but: BUMP!
... would be really nice to have mono-addins support gtk3 for building all the other applications which depend on it!
Thanks!

j-4 commented Nov 20, 2013

I don't want to be rude, but: BUMP!
... would be really nice to have mono-addins support gtk3 for building all the other applications which depend on it!
Thanks!

@@ -0,0 +1,289 @@
2013-10-12 Robert Nordan <rpvn@robpvn.net>

This comment has been minimized.

@Therzok

Therzok Nov 20, 2013

Member

This file should only have your entry in it.

@Therzok

Therzok Nov 20, 2013

Member

This file should only have your entry in it.

This comment has been minimized.

@Therzok

Therzok Nov 20, 2013

Member

In short, you copied other folder's changelog entries in here.

@Therzok

Therzok Nov 20, 2013

Member

In short, you copied other folder's changelog entries in here.

This comment has been minimized.

@robpvn

robpvn Nov 25, 2013

Contributor

Well, I figured it might as well be preserved since the GTK#3 GUI is just the a copy of the old GUI but ported to GTK#3. All in all though, the changelog file seems like something of an anachronism, I just left it in since the original still had one.

@robpvn

robpvn Nov 25, 2013

Contributor

Well, I figured it might as well be preserved since the GTK#3 GUI is just the a copy of the old GUI but ported to GTK#3. All in all though, the changelog file seems like something of an anachronism, I just left it in since the original still had one.

@robpvn

This comment has been minimized.

Show comment
Hide comment
@robpvn

robpvn Oct 4, 2014

Contributor

It's now a year since I submitted this the first time, but since master merged without issues I hope the code should still be fully functional and more or less up-to-date. I've removed the old info from the changelog, in case that was the blocker for merging this in.

Contributor

robpvn commented Oct 4, 2014

It's now a year since I submitted this the first time, but since master merged without issues I hope the code should still be fully functional and more or less up-to-date. I've removed the old info from the changelog, in case that was the blocker for merging this in.

@Therzok

This comment has been minimized.

Show comment
Hide comment
@Therzok

Therzok Oct 4, 2014

Member

@robpvn Heya, I suppose a rebase would work better than a merge (especially since you had no conflicts).

Member

Therzok commented Oct 4, 2014

@robpvn Heya, I suppose a rebase would work better than a merge (especially since you had no conflicts).

@robpvn

This comment has been minimized.

Show comment
Hide comment
@robpvn

robpvn Oct 4, 2014

Contributor

OK, so I'm not totally familiar with rebasing. Should I revert the commit where i merged master into gui-gtk3 and then rebase gui-gtk3 on master?

Contributor

robpvn commented Oct 4, 2014

OK, so I'm not totally familiar with rebasing. Should I revert the commit where i merged master into gui-gtk3 and then rebase gui-gtk3 on master?

slluis added a commit that referenced this pull request Nov 4, 2014

Merge pull request #8 from robpvn/gui-gtk3
Add a GTK#3 Gui project

@slluis slluis merged commit feeed2c into mono:master Nov 4, 2014

@slluis

This comment has been minimized.

Show comment
Hide comment
@slluis

slluis Nov 4, 2014

Member

Thanks!

Member

slluis commented Nov 4, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment