Skip to content


Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Feb 12, 2011
  1. Relax XSD to accept non-integer parameter values (e.g. double and str…

    Sebastien Pouliot authored
    * Settings.cs: Allow settings configuration to reflect using double and
    string (in addition to integer) since some rules can use those types.
    * gendarme.xsd: Relax the parameter value to xs:string
    Fix bug #671178
Commits on Feb 11, 2011
  1. Cecil's ExceptionHandler.HandlerEnd can be null

    Sebastien Pouliot authored
    * Impl/ExecutionPathFactory.cs: Do not throw an ArgumentNullException if
    'end' is null since Cecil's ExceptionHandler.HandlerEnd can be null when
    the method's last instruction is part of the handler. Uncommon IL that
    can be generated by CSC
Commits on Feb 10, 2011
  1. Add test case that throws when code is compiled with CSC

    Sebastien Pouliot authored
    * Test/DontDestroyStackTraceTest.cs: This new test case will throw when
    compiled with CSC (VS2008) since HandlerEnd points past the end of the
    method and Cecil replace this with a null entry. See bnc #668925
Commits on Feb 9, 2011
  1. Fix case where no parameters is different than "unknown # of" parameters

    Sebastien Pouliot authored
    * AvoidUnnecessarySpecializationRule.cs: Fix usage of MethodSignature
    where unspecified parameters means "unknown", not 0.
    * Test/AvoidUnnecessarySpecializationTest.cs: Add test case from bnc
    669974 and remove [Ignore] from an existing test case
    * ../Gendarme.Rules.Smells/AvoidLongParameterListsRule.cs: Apply rule
    * ../../self-test.ignore: Remove fixed entries
  2. Add ternary if support in AvoidAlwaysNullFieldRule

    Sebastien Pouliot authored
    * AvoidAlwaysNullFieldRule.cs: Add ternary if (?:) support
    * Test/AvoidAlwaysNullFieldTest.cs: Add test cases and remove [Ignore]
    on an existing test case.
Commits on Jan 25, 2011
  1. Add support for A and N defect types in gd2i

    Sebastien Pouliot authored
    * gd2i.cs: Track Uri instead of Name since the later is no more unique
    across namespaces. Add support for A[ssembly] and N[amespace] defects to
    fix bug 666567
Commits on Jan 24, 2011
  1. add missing rock and rule/tests to csproj files

    Sebastien Pouliot authored
  2. add S.R.S.dll to unit tests project file

    Sebastien Pouliot authored
  3. Add [FxCopCompatibility] to DoNotForgetNotImplementedMethodsRule

    Sebastien Pouliot authored
    * DoNotForgetNotImplementedMethodsRule.cs: Add [FxCopCompatibility] to
    allow a single [SupressMessage] to work on it (and the more complete, wrt
    CA1065, DoNotThrowInUnexpectedLocationRule). Fix bug #665317
Commits on Jan 23, 2011
  1. Add support for automatic properties wrt AvoidLackOfCohesionOfMethods…

    Sebastien Pouliot authored
    * AvoidLackOfCohesionOfMethodsRule.cs: Add support for automatic
    * Add S.R.S.dll when building tests
    * Test/AvoidLackOfCohesionOfMethodsTest.cs: Add test cases with different
    cases of automatic properties using data contracts.
  2. Add missing [FxCopCompatibility] attribute on EnsureLocalDisposalRule

    Sebastien Pouliot authored
    * EnsureLocalDisposalRule.cs: Add [FxCopCompatibility] on CA2000
    * ../../tools/unsupported/mapper/fxcop.missing: Remove CA2000 from list
  3. Allow 'is' as a valid null check on parameters

    Sebastien Pouliot authored
    * CheckParametersNullityInVisibleMethodsRule.cs: Allow 'is' as a valid
    null check on parameters
    * Test/CheckParametersNullityInVisibleMethodsTest.cs: Test case for
    above, provided by Iristyle
  4. Fix generic parameter in return value check in AvoidMethodWithUnusedG…

    Sebastien Pouliot authored
    * AvoidMethodWithUnusedGenericTypeRule.cs: Fix the check for generic
    parameter in return value, e.g. IEnumerable<T>
    * Test/AvoidMethodWithUnusedGenericTypeTest.cs: Add test case for above
  5. Ignore (i.e. no defects on) generic constraints for ConsiderAddingInt…

    Sebastien Pouliot authored
    * ConsiderAddingInterfaceRule.cs: Do not report defects if generic
    constraints are present on types or methods since we're not (presently)
    comparing them to ensure they match. Change how the Defect is created to
    ensure source information (file/lines) are available (if the target is
    not an interface).
    * Test/ConsiderAddingInterfaceTest.cs: Test cases with some generic
  6. Fix base interfaces in ConsiderAddingInterfaceRule (part of 665161)

    Sebastien Pouliot authored
    * ConsiderAddingInterfaceRule.cs: Check if the interface is implementing
    other interfaces and consider them too.
    * Test/ConsiderAddingInterfaceTest.cs: Add test case for above and
    another one, presently ignored, for generic constraints
  7. Ignore [CompilerGenerated] code in AvoidMethodWithUnusedGenericTypeRule

    Sebastien Pouliot authored
    * AvoidMethodWithUnusedGenericTypeRule.cs: Ignore generated code
  8. Add support for [SuppressMessage] on properties/events

    Sebastien Pouliot authored
    * Gendarme.Framework.Engines/SuppressMessageEngine.cs: [SuppressMessage]
    on properties must be copied to the getter and setters (since this is
    where the defect will likely be found) just like [SuppressMessage] on
    events must be copied on the adder/remover/invoker... Fix bug #665171
    * Test/Gendarme.Framework.Engines/SuppressMessageAttributeTest.cs:
    Add properties and events test cases on the MethodRule.
  9. Add test cases for AvoidPublicInstanceFieldsRule wrt events

    Sebastien Pouliot authored
    * AvoidPublicInstanceFieldsRule.cs: Add a check for HasFields
    * Test/AvoidPublicInstanceFieldsTest.cs: Add test cases for events
  10. Add missing null check after resolving in AvoidRefAndOutParametersRule

    Sebastien Pouliot authored
    * AvoidRefAndOutParametersRule.cs: Add missing null check after
    resolving a type.
  11. Ignore methods dictated by interfaces with AvoidRefAndOutParametersRule

    Sebastien Pouliot authored
    * AvoidRefAndOutParametersRule.cs: Ignore method signatures that are
    dictated by an implemented interface. Such defects will be reported on
    the interface definition. Fix bug #665144
    * Test/AvoidRefAndOutParametersTest.cs: Test case for the above.
  12. Lower confidence of EnsureLocalDisposalRule defects on fluent-like APIs

    Sebastien Pouliot authored
    * EnsureLocalDisposalRule.cs: Lower confidence on fluent-like APIs
    * Test/EnsureLocalDisposalTest.cs: Add fluent-like test cases based on
    case provided by Iristyle
  13. Handle array types correctly in ReviewLinqMethodRule. FIx bnc664556

    Sebastien Pouliot authored
    * ReviewLinqMethodRule.cs: Handle array types correctly
    * Test/ReviewLinqMethodTest.cs: Test case for above. Provided by Antoine
    Vandecreme  <>
  14. Add missing Globalization to rules.xml

    Sebastien Pouliot authored
    * rules.xml: Add missing Globalization assembly to self-test, default
    and it's own category. Add comments about other 'specialization'
    assemblies that are not part of the 'default' rule set
  15. Update DocumentationUri to default to the new documentation wiki pages

    Sebastien Pouliot authored
    * Rule.cs: Update DocumentationUri to github's new documentation
    wiki. Currently hard-coded to 2.10
Commits on Jan 15, 2011
  1. Bump win32 installer version number to 2.10

    Sebastien Pouliot authored
    * Product.wxs: Bump win32 installer version number to 2.10
Commits on Jan 13, 2011
  1. [mono-tools] fix gsharp compilation

    Marek Habersack authored
Commits on Jan 12, 2011
  1. Fix false positive in CheckParametersNullityInVisibleMethodsRule

    Sebastien Pouliot authored
    * CheckParametersNullityInVisibleMethodsRule.cs: Fix parameter index
    calculation for TraceBack
    * Test/CheckParametersNullityInVisibleMethodsTest.cs: Add new test case
    provided by Iristyle.
  2. Remove deleted file from Gendarme.Rules.Exceptions.csproj

    Sebastien Pouliot authored
  3. Gendarme.Rules.Gendarme.* should inherit from GendarmRule

    Sebastien Pouliot authored
    * ReviewAttributesOnRulesRule.cs:
    * UseCorrectSuffixRule.cs:
    	Inherit from GendarmeRule so they are not executed against
    	non-rule assemblies (which saves times and avoid defects that
    	do not make sense on non-gendarme code).
    Thanks to Antoine for spotting those defects.
Commits on Jan 11, 2011
  1. @boothead

    Fixed README to point to git instead of SVN

    boothead authored Sebastien Pouliot committed
  2. Fix 'make distcheck' until 'distuninstallcheck'

    Sebastien Pouliot authored
    * Bump to 2.10, reorder to avoid warnings
    * Add missing subdir
    * gendarme/ Remove (old) unneeded entries
    * gendarme/tools/unsupported/mapper/ Fix
    * Mono.Profiler/heap-snapshot-explorer/AssemblyInfo.cs:
    * Mono.Profiler/heap-snapshot-viewer/AssemblyInfo.cs:
    	Fix compilation
  3. Fix previous commit on AvoidUncalledPrivateCodeRule.cs

    Sebastien Pouliot authored
    * AvoidUncalledPrivateCodeRule.cs: Avoid calli but still allow more than
    call[virt] and newobj (e.g. ldftn[virt])
  4. Fix a possible NRE in AvoidUncalledPrivateCodeRule with CallSite

    Sebastien Pouliot authored
    * AvoidUncalledPrivateCodeRule.cs: Call GetMethod rock to avoid
    CallSite instance which would throw a NRE later. Fix a new test
    case from the regression library.
  5. Fix "not quite infinite" loop in DoNotDestroyStackTraceRule (bnc 663259)

    Sebastien Pouliot authored
    * DoNotDestroyStackTraceRule.cs: Report a defect if a catch handler could
    not be analyzed due to its complexity. Fix for bug #663259
    * Impl/ExecutionPathFactory.cs: Hardcode a limit on the number of execution
    path being created to avoid exhausting all available memory.
  6. Add missing [FxCopCompatibility] on NonConstantStaticFieldsShouldNotB…

    Sebastien Pouliot authored
    * NonConstantStaticFieldsShouldNotBeVisibleRule.cs: Add missing [FxCop
    Compatibility] attribute. Patch by Iristyle
Something went wrong with that request. Please try again.