Commits on Sep 15, 2010
  1. Move gsharp to 4.0 where possible

    Andrew Jorgensen committed Sep 15, 2010
Commits on Sep 14, 2010
  1. @marek-safar

    [639072] Initialize evaluator before using it.

    marek-safar committed with Andrew Jorgensen Sep 14, 2010
  2. Update Gendarme's NEWS for 2.8.0

    * gendarme/NEWS: Add 2.8.0 news + 10 new rules
    Sebastien Pouliot committed with Andrew Jorgensen Sep 5, 2010
  3. @rolfbjarne

    DelegatesPassedToNativeCodeMustIncludeExceptionHandlingRule: mark lea…

    …ve.s as safe
    
    2010-08-27  Rolf Bjarne Kvinge  <RKvinge@novell.com>
    
    	* DelegatesPassedToNativeCodeMustIncludeExceptionHandlingRule.cs: Mark leave.s
    	as safe (just as leave is safe too).
    rolfbjarne committed with Andrew Jorgensen Aug 27, 2010
Commits on Sep 1, 2010
  1. @rolfbjarne

    DelegatesPassedToNativeCodeMustIncludeExceptionHandlingRule: peer rev…

    …iewed
    
    In gendarme:
    2010-08-27  Rolf Bjarne Kvinge  <RKvinge@novell.com>
    
    	* self-test.ignore: Add an entry to allow
    	DelegatesPassedToNativeCodeMustIncludeExceptionHandlingRule to catch all
    	exceptions it may throw.
    
    In gendarme/rules/Gendarme.Rules.Interoperability:
    2010-08-27  Rolf Bjarne Kvinge  <RKvinge@novell.com>
    
    	* DelegatesPassedToNativeCodeMustIncludeExceptionHandlingRule.cs:
    	Make the example code more extensive and explain the rule a bit better.
    	Initialize member variables in the the ctor to avoid null checks all
    	the time. Use HashSet instead of List when we only check for existence.
    	Use bitmasks to exclude methods to process, and generate the bitmasks
    	statically. Change rule logic to mark all code in a method that is
    	covered by a catch-all exception clause as safe - and the remaining
    	code must be included in a list of safe instructions for the rule to
    	accept it. Fix other minor issues as noted by either self-test or
    	peer-review.
    
    In gendarme/rules/Gendarme.Rules.Interoperability/Test:
    2010-08-27  Rolf Bjarne Kvinge  <RKvinge@novell.com>
    
    	* DelegatesPassedToNativeCodeMustIncludeExceptionHandlingTest.cs:
    	Remove CWL's from catch blocks in methods that are safe, and add
    	CWL's to methods that should not be safe. In general update to
    	make the tests work with the more correct version of the rule.
    rolfbjarne committed with Andrew Jorgensen Aug 27, 2010
Commits on Aug 26, 2010
  1. Bump version to 2.8

    Andrew Jorgensen committed Aug 26, 2010
Commits on Aug 22, 2010
  1. Fix 'self-test'

    rules/Gendarme.Rules.Maintainability/AvoidUnnecessarySpecializationRule.cs: Apply
    the rule to itself :)
    Sebastien Pouliot committed Aug 22, 2010
  2. Ignore files

    Sebastien Pouliot committed Aug 22, 2010
Commits on Aug 19, 2010
  1. Fix an exception when analyzing code using multidim arrays

    * AvoidUnnecessarySpecializationRule.cs: Ensure we have a GenericInstance
    Method before casting since this could be a special method (e.g. a Set
    method generated for multidimentional arrays)
    
    * Test/AvoidUnnecessarySpecializationTest.cs: Add test case where a "not
    really existing" Set method is called by the code
    Sebastien Pouliot committed Aug 18, 2010
  2. Add/update .gitignore files

    Sebastien Pouliot committed Aug 18, 2010
Commits on Aug 6, 2010
  1. Add support of string resources to ProvideCorrectArgumentsToFormattin…

    …gMethodsRule
    
    * AUTHORS: Add Antoine Vandecreme
    * self-test.ignore: Add entry to ignore PreferEmptyInstanceOverNullRule
    on ProvideCorrectArgumentsToFormattingMethodsRule since null and
    empty have different meaning in the rule
    * rules/Gendarme.Rules.Correctness/Makefile.am: Add support for resources
    * rules/Gendarme.Rules.Correctness/ProvideCorrectArgumentsToFormattingMethodsRule.cs:
    Add support of string resources as format
    * rules/Gendarme.Rules.Correctness/Test/Tests.Rules.Correctness.csproj: Add
    Resource.resx and Resource.Designer.cs to project
    * rules/Gendarme.Rules.Correctness/Test/Resource.resx: Added
    * rules/Gendarme.Rules.Correctness/Test/Resource.Designer.cs: Added
    * rules/Gendarme.Rules.Correctness/Test/ProvideCorrectArgumentsToFormattingMethodsTest.cs:
    Add tests cases with string resources as format
    * rules/common.make: Add support for resources
    Sebastien Pouliot committed Aug 6, 2010
  2. Fix #622972 wrt generic calls in CheckParametersNullityInVisibleMetho…

    …dsRule
    
    * CheckParametersNullityInVisibleMethodsRule.cs: Ignore box instruction
    in calls (e.g. using generics) to find the parameter in CheckCall method.
    Avoid checking parameters that are already known do to a null check (in
    CheckArgument method). Stop instruction analysis if/when all parameters
    are known to have null checks.
    
    * Test/CheckParametersNullityInVisibleMethodsTest.cs: Converted all test
    cases, provided by Tobias Schönit in bnc622972, into unit tests.
    Sebastien Pouliot committed Aug 6, 2010
Commits on Aug 5, 2010
  1. Add Count() method. Fix Clear(int) when > 32. Add more test cases to …

    …get full coverage.
    Sebastien Pouliot committed Aug 5, 2010
  2. Patch to use SAX instead of DOM xml writer. Provided by Eric Zeitler …

    …(and modified a bit by myself). Fix bug #626129
    
    -This line, and those below, will be ignored--
    Sebastien Pouliot committed Aug 5, 2010
Commits on Jul 22, 2010
  1. @grendello

    2010-07-22 Marek Habersack <mhabersack@novell.com>

    	* MasterMetadata.cs: added code to show values of enums in the
    	extra info box.
    
    
    svn path=/trunk/mono-tools/; revision=160719
    grendello committed Jul 22, 2010
Commits on Jul 15, 2010
  1. In Test:

    2010-07-14  Sebastien Pouliot  <sebastien@ximian.com>
    
    	* NewLineLiteralTest.cs: Complete test coverage for rule
    
    In .:
    2010-07-14  Sebastien Pouliot  <sebastien@ximian.com>
    
    	* NewLineLiteralRule.cs: Fix decimal (needs hexadecimal) for
    	control characters. Remove XML doc (used for rules doc only)
    	and avoid a few allocations since we're using a StringBuilder
    	* Makefile.am: Compile tests without optimizations so GMCS
    	won't replace a "" with String.Empty
    
    
    svn path=/trunk/mono-tools/; revision=160395
    Sebastien Pouliot committed Jul 15, 2010
  2. 2010-07-14 Antoine Vandecreme <avandecreme@sopragroup.com>

    	* NewLineLiteralRule.cs: Format specials char to be
    	human readable and XML compliants
    
    
    svn path=/trunk/mono-tools/; revision=160394
    Sebastien Pouliot committed Jul 15, 2010
Commits on Jun 29, 2010
  1. 2010-06-28 Sebastien Pouliot <sebastien@ximian.com>

    	* gendarme.xsl: Update styles to be closer to the current Mono 
    	wiki style - which is also closer to Gendarme's logo colors.
    
    
    svn path=/trunk/mono-tools/; revision=159644
    Sebastien Pouliot committed Jun 29, 2010
Commits on Jun 24, 2010
  1. 2010-06-23 Sebastien Pouliot <sebastien@ximian.com>

    	* self-test.ignore: Remove entries fixed on the console runner, one
    	that does not apply to recent Mono and add comments about defects
    	that can/will be fixed with FX4.0
    
    
    svn path=/trunk/mono-tools/; revision=159471
    Sebastien Pouliot committed Jun 24, 2010
  2. 2010-06-23 Sebastien Pouliot <sebastien@ximian.com>

    	* TextResultWriter.cs: Apply AvoidRedundancyInMethodNameRule,
    	AvoidRepetitiveCallsToPropertiesRule and AvoidLackOfCohesionOfMethodsRule
    	* XmlResultWriter.cs: Apply AvoidRedundancyInMethodNameRule
    
    
    svn path=/trunk/mono-tools/; revision=159470
    Sebastien Pouliot committed Jun 24, 2010
Commits on Jun 23, 2010
  1. 2010-06-22 Sebastien Pouliot <sebastien@ximian.com>

    	* self-test.ignore: Remove entries fixed with AvoidLargeClassesRule
    
    
    svn path=/trunk/mono-tools/; revision=159404
    Sebastien Pouliot committed Jun 23, 2010
  2. 2010-06-22 Sebastien Pouliot <sebastien@ximian.com>

    	* MonoCompatibilityReviewRule.cs: Apply AvoidLargeClassesRule
    
    
    svn path=/trunk/mono-tools/; revision=159403
    Sebastien Pouliot committed Jun 23, 2010
Commits on Jun 22, 2010
  1. 2010-06-22 Sebastien Pouliot <sebastien@ximian.com>

    	* UseObjectDisposedExceptionRule.cs: Apply AvoidLargeClassesRule
    
    
    svn path=/trunk/mono-tools/; revision=159402
    Sebastien Pouliot committed Jun 22, 2010
  2. 2010-06-22 Sebastien Pouliot <sebastien@ximian.com>

    	* AvoidMethodsWithSideEffectsInConditionalCodeRule.cs: Apply 
    	AvoidLargeClassesRule
    
    
    svn path=/trunk/mono-tools/; revision=159401
    Sebastien Pouliot committed Jun 22, 2010
  3. 2010-06-22 Sebastien Pouliot <sebastien@ximian.com>

    	* PreferEmptyInstanceOverNullRule.cs: Apply AvoidLargeClassesRule
    
    
    svn path=/trunk/mono-tools/; revision=159400
    Sebastien Pouliot committed Jun 22, 2010
  4. 2010-06-22 Sebastien Pouliot <sebastien@ximian.com>

    	* SuppressMessageEngine.cs: Apply AvoidLargeClassesRule
    
    
    svn path=/trunk/mono-tools/; revision=159399
    Sebastien Pouliot committed Jun 22, 2010
  5. @marek-safar

    set eol

    svn path=/trunk/mono-tools/; revision=159353
    marek-safar committed Jun 22, 2010
  6. @marek-safar

    2010-06-22 Marek Safar <marek.safar@gmail.com>

    	* Metadata.cs, CompareContext.cs, Masterinfo.cs: Compare correctly
    	generic and non-generic method overloads.
    
    
    svn path=/trunk/mono-tools/; revision=159351
    marek-safar committed Jun 22, 2010
Commits on Jun 20, 2010
  1. remove some (9) defects and add a new (duplicated) one to ignore

    svn path=/trunk/mono-tools/; revision=159227
    Sebastien Pouliot committed Jun 20, 2010
  2. 2010-06-20 Sebastien Pouliot <sebastien@ximian.com>

    	* ConsiderUsingStopwatchRule.cs:
    	* PreferStringIsNullOrEmptyRule.cs:
    		Apply AvoidRepetitiveCallsToPropertiesRule
    
    
    svn path=/trunk/mono-tools/; revision=159226
    Sebastien Pouliot committed Jun 20, 2010
  3. 2010-06-20 Sebastien Pouliot <sebastien@ximian.com>

    	* ProvideValidXmlStringRule.cs:
    	* ProvideValidXPathExpressionRule.cs:
    		Apply AvoidRepetitiveCallsToPropertiesRule
    
    
    svn path=/trunk/mono-tools/; revision=159225
    Sebastien Pouliot committed Jun 20, 2010
  4. 2010-06-20 Sebastien Pouliot <sebastien@ximian.com>

    	* AvoidMessageChainsRule.cs: Apply AvoidRepetitiveCallsToPropertiesRule
    
    
    svn path=/trunk/mono-tools/; revision=159224
    Sebastien Pouliot committed Jun 20, 2010
  5. In Test:

    2010-06-20  Sebastien Pouliot  <sebastien@ximian.com>
    
    	* AvoidRepetitiveCallsToPropertiesTest.cs: Add property access 
    	test case
    
    In .:
    2010-06-20  Sebastien Pouliot  <sebastien@ximian.com>
    
    	* AvoidRepetitiveCallsToPropertiesRule.cs: Fix properties access
    	* ReviewLinqMethodRule.cs: Apply AvoidRepetitiveCallsToPropertiesRule
    
    
    svn path=/trunk/mono-tools/; revision=159223
    Sebastien Pouliot committed Jun 20, 2010
  6. update from win32 side

    svn path=/trunk/mono-tools/; revision=159222
    Sebastien Pouliot committed Jun 20, 2010
  7. add a known (and ok) ignore entry for code duplication between the tw…

    …o CC implementations
    
    svn path=/trunk/mono-tools/; revision=159220
    Sebastien Pouliot committed Jun 20, 2010