Permalink
Commits on Mar 18, 2011
  1. Fix documentation formatting

    Sebastien Pouliot committed Mar 18, 2011
Commits on Feb 12, 2011
  1. Relax XSD to accept non-integer parameter values (e.g. double and str…

    …ings)
    
    * Settings.cs: Allow settings configuration to reflect using double and
    string (in addition to integer) since some rules can use those types.
    * gendarme.xsd: Relax the parameter value to xs:string
    
    Fix bug #671178
    Sebastien Pouliot committed Feb 12, 2011
Commits on Feb 11, 2011
  1. Cecil's ExceptionHandler.HandlerEnd can be null

    * Impl/ExecutionPathFactory.cs: Do not throw an ArgumentNullException if
    'end' is null since Cecil's ExceptionHandler.HandlerEnd can be null when
    the method's last instruction is part of the handler. Uncommon IL that
    can be generated by CSC
    Sebastien Pouliot committed Feb 10, 2011
Commits on Feb 10, 2011
  1. Add test case that throws when code is compiled with CSC

    * Test/DontDestroyStackTraceTest.cs: This new test case will throw when
    compiled with CSC (VS2008) since HandlerEnd points past the end of the
    method and Cecil replace this with a null entry. See bnc #668925
    Sebastien Pouliot committed Feb 9, 2011
Commits on Feb 9, 2011
  1. Fix case where no parameters is different than "unknown # of" parameters

    * AvoidUnnecessarySpecializationRule.cs: Fix usage of MethodSignature
    where unspecified parameters means "unknown", not 0.
    * Test/AvoidUnnecessarySpecializationTest.cs: Add test case from bnc
    669974 and remove [Ignore] from an existing test case
    * ../Gendarme.Rules.Smells/AvoidLongParameterListsRule.cs: Apply rule
    * ../../self-test.ignore: Remove fixed entries
    Sebastien Pouliot committed Feb 9, 2011
  2. Add ternary if support in AvoidAlwaysNullFieldRule

    * AvoidAlwaysNullFieldRule.cs: Add ternary if (?:) support
    * Test/AvoidAlwaysNullFieldTest.cs: Add test cases and remove [Ignore]
    on an existing test case.
    Sebastien Pouliot committed Feb 9, 2011
Commits on Jan 25, 2011
  1. Add support for A and N defect types in gd2i

    * gd2i.cs: Track Uri instead of Name since the later is no more unique
    across namespaces. Add support for A[ssembly] and N[amespace] defects to
    fix bug 666567
    Sebastien Pouliot committed Jan 25, 2011
Commits on Jan 24, 2011
  1. add missing rock and rule/tests to csproj files

    Sebastien Pouliot committed Jan 24, 2011
  2. add S.R.S.dll to unit tests project file

    Sebastien Pouliot committed Jan 24, 2011
  3. Add [FxCopCompatibility] to DoNotForgetNotImplementedMethodsRule

    * DoNotForgetNotImplementedMethodsRule.cs: Add [FxCopCompatibility] to
    allow a single [SupressMessage] to work on it (and the more complete, wrt
    CA1065, DoNotThrowInUnexpectedLocationRule). Fix bug #665317
    Sebastien Pouliot committed Jan 24, 2011
Commits on Jan 23, 2011
  1. Add support for automatic properties wrt AvoidLackOfCohesionOfMethods…

    …Rule
    
    * AvoidLackOfCohesionOfMethodsRule.cs: Add support for automatic
    properties
    * Makefile.am: Add S.R.S.dll when building tests
    * Test/AvoidLackOfCohesionOfMethodsTest.cs: Add test cases with different
    cases of automatic properties using data contracts.
    Sebastien Pouliot committed Jan 23, 2011
  2. Add missing [FxCopCompatibility] attribute on EnsureLocalDisposalRule

    * EnsureLocalDisposalRule.cs: Add [FxCopCompatibility] on CA2000
    * ../../tools/unsupported/mapper/fxcop.missing: Remove CA2000 from list
    
    Iristyle@6cb7c22
    Sebastien Pouliot committed Jan 22, 2011
  3. Allow 'is' as a valid null check on parameters

    * CheckParametersNullityInVisibleMethodsRule.cs: Allow 'is' as a valid
    null check on parameters
    
    * Test/CheckParametersNullityInVisibleMethodsTest.cs: Test case for
    above, provided by Iristyle
    Sebastien Pouliot committed Jan 22, 2011
  4. Fix generic parameter in return value check in AvoidMethodWithUnusedG…

    …enericTypeRule
    
    * AvoidMethodWithUnusedGenericTypeRule.cs: Fix the check for generic
    parameter in return value, e.g. IEnumerable<T>
    * Test/AvoidMethodWithUnusedGenericTypeTest.cs: Add test case for above
    Sebastien Pouliot committed Jan 22, 2011
  5. Ignore (i.e. no defects on) generic constraints for ConsiderAddingInt…

    …erfaceRule
    
    * ConsiderAddingInterfaceRule.cs: Do not report defects if generic
    constraints are present on types or methods since we're not (presently)
    comparing them to ensure they match. Change how the Defect is created to
    ensure source information (file/lines) are available (if the target is
    not an interface).
    
    * Test/ConsiderAddingInterfaceTest.cs: Test cases with some generic
    constraints
    Sebastien Pouliot committed Jan 22, 2011
  6. Fix base interfaces in ConsiderAddingInterfaceRule (part of 665161)

    * ConsiderAddingInterfaceRule.cs: Check if the interface is implementing
    other interfaces and consider them too.
    * Test/ConsiderAddingInterfaceTest.cs: Add test case for above and
    another one, presently ignored, for generic constraints
    Sebastien Pouliot committed Jan 21, 2011
  7. Ignore [CompilerGenerated] code in AvoidMethodWithUnusedGenericTypeRule

    * AvoidMethodWithUnusedGenericTypeRule.cs: Ignore generated code
    Sebastien Pouliot committed Jan 20, 2011
  8. Add support for [SuppressMessage] on properties/events

    * Gendarme.Framework.Engines/SuppressMessageEngine.cs: [SuppressMessage]
    on properties must be copied to the getter and setters (since this is
    where the defect will likely be found) just like [SuppressMessage] on
    events must be copied on the adder/remover/invoker... Fix bug #665171
    
    * Test/Gendarme.Framework.Engines/SuppressMessageAttributeTest.cs:
    Add properties and events test cases on the MethodRule.
    Sebastien Pouliot committed Jan 20, 2011
  9. Add test cases for AvoidPublicInstanceFieldsRule wrt events

    * AvoidPublicInstanceFieldsRule.cs: Add a check for HasFields
    * Test/AvoidPublicInstanceFieldsTest.cs: Add test cases for events
    Sebastien Pouliot committed Jan 20, 2011
  10. Add missing null check after resolving in AvoidRefAndOutParametersRule

    * AvoidRefAndOutParametersRule.cs: Add missing null check after
    resolving a type.
    Sebastien Pouliot committed Jan 19, 2011
  11. Ignore methods dictated by interfaces with AvoidRefAndOutParametersRule

    * AvoidRefAndOutParametersRule.cs: Ignore method signatures that are
    dictated by an implemented interface. Such defects will be reported on
    the interface definition. Fix bug #665144
    * Test/AvoidRefAndOutParametersTest.cs: Test case for the above.
    Sebastien Pouliot committed Jan 19, 2011
  12. Lower confidence of EnsureLocalDisposalRule defects on fluent-like APIs

    * EnsureLocalDisposalRule.cs: Lower confidence on fluent-like APIs
    * Test/EnsureLocalDisposalTest.cs: Add fluent-like test cases based on
    case provided by Iristyle
    Sebastien Pouliot committed Jan 19, 2011
  13. Handle array types correctly in ReviewLinqMethodRule. FIx bnc664556

    * ReviewLinqMethodRule.cs: Handle array types correctly
    * Test/ReviewLinqMethodTest.cs: Test case for above. Provided by Antoine
    Vandecreme  <ant.vand@gmail.com>
    Sebastien Pouliot committed Jan 18, 2011
  14. Add missing Globalization to rules.xml

    * rules.xml: Add missing Globalization assembly to self-test, default
    and it's own category. Add comments about other 'specialization'
    assemblies that are not part of the 'default' rule set
    Sebastien Pouliot committed Jan 15, 2011
  15. Update DocumentationUri to default to the new documentation wiki pages

    * Rule.cs: Update DocumentationUri to github's new documentation
    wiki. Currently hard-coded to 2.10
    Sebastien Pouliot committed Jan 15, 2011
Commits on Jan 15, 2011
  1. Bump win32 installer version number to 2.10

    * Product.wxs: Bump win32 installer version number to 2.10
    Sebastien Pouliot committed Jan 15, 2011
Commits on Jan 13, 2011
  1. [mono-tools] fix gsharp compilation

    Marek Habersack committed Jan 13, 2011
Commits on Jan 12, 2011
  1. Fix false positive in CheckParametersNullityInVisibleMethodsRule

    * CheckParametersNullityInVisibleMethodsRule.cs: Fix parameter index
    calculation for TraceBack
    * Test/CheckParametersNullityInVisibleMethodsTest.cs: Add new test case
    provided by Iristyle.
    Sebastien Pouliot committed Jan 12, 2011
  2. Remove deleted file from Gendarme.Rules.Exceptions.csproj

    Sebastien Pouliot committed Jan 12, 2011
  3. Gendarme.Rules.Gendarme.* should inherit from GendarmRule

    * ReviewAttributesOnRulesRule.cs:
    * UseCorrectSuffixRule.cs:
    	Inherit from GendarmeRule so they are not executed against
    	non-rule assemblies (which saves times and avoid defects that
    	do not make sense on non-gendarme code).
    
    Thanks to Antoine for spotting those defects.
    Sebastien Pouliot committed Jan 12, 2011
Commits on Jan 11, 2011
  1. Fixed README to point to git instead of SVN

    Ben Ford committed with Sebastien Pouliot Jan 11, 2011
  2. Fix 'make distcheck' until 'distuninstallcheck'

    * configure.in: Bump to 2.10, reorder to avoid warnings
    * Makefile.am: Add missing subdir
    * gendarme/Makefile.am: Remove (old) unneeded entries
    * gendarme/tools/unsupported/mapper/Makefile.am: Fix
    
    * Mono.Profiler/heap-snapshot-explorer/AssemblyInfo.cs:
    * Mono.Profiler/heap-snapshot-viewer/AssemblyInfo.cs:
    	Fix compilation
    Sebastien Pouliot committed Jan 11, 2011
  3. Fix previous commit on AvoidUncalledPrivateCodeRule.cs

    * AvoidUncalledPrivateCodeRule.cs: Avoid calli but still allow more than
    call[virt] and newobj (e.g. ldftn[virt])
    Sebastien Pouliot committed Jan 11, 2011
  4. Fix a possible NRE in AvoidUncalledPrivateCodeRule with CallSite

    * AvoidUncalledPrivateCodeRule.cs: Call GetMethod rock to avoid
    CallSite instance which would throw a NRE later. Fix a new test
    case from the regression library.
    Sebastien Pouliot committed Jan 11, 2011
  5. Fix "not quite infinite" loop in DoNotDestroyStackTraceRule (bnc 663259)

    * DoNotDestroyStackTraceRule.cs: Report a defect if a catch handler could
    not be analyzed due to its complexity. Fix for bug #663259
    * Impl/ExecutionPathFactory.cs: Hardcode a limit on the number of execution
    path being created to avoid exhausting all available memory.
    Sebastien Pouliot committed Jan 11, 2011