Permalink
Commits on Dec 4, 2008
  1. 2008-12-03 Jesse Jones <jesjones@mindspring.com>

    	* ConsoleRunner.cs: --help says "assemblies" instead of
    	assembly.
    	[Backport of r120662]
    
    
    svn path=/branches/mono-2-2/mono-tools/; revision=120671
    Sebastien Pouliot committed Dec 4, 2008
  2. 2008-12-03 Sebastien Pouliot <sebastien@ximian.com>

    	* AvoidLackOfCohesionOfMethodsRule.cs: Fix documentation (wrong rule)
    	* AvoidDeepInheritanceTreeRule.cs: Fix documentation (wrong rule)
    	[Backport of r120667]
    
    
    svn path=/branches/mono-2-2/mono-tools/; revision=120668
    Sebastien Pouliot committed Dec 4, 2008
Commits on Nov 28, 2008
  1. 2008-11-27 Sebastien Pouliot <sebastien@ximian.com>

    	* Wizard.cs: Workaround bug #439943 which is not part of Mono 2.2
    	but is fixed on HEAD
    
    
    svn path=/branches/mono-2-2/mono-tools/; revision=120203
    Sebastien Pouliot committed Nov 28, 2008
  2. 2008-11-27 Sebastien Pouliot <sebastien@ximian.com>

    	* Makefile.am: Include the framework unit tests in the dist.
    	[Backport of r120197]
    
    
    svn path=/branches/mono-2-2/mono-tools/; revision=120202
    Sebastien Pouliot committed Nov 28, 2008
Commits on Nov 27, 2008
  1. 2008-11-26 Sebastien Pouliot <sebastien@ximian.com>

    	* ConsiderUsingStopwatchRule.cs: Use TraceBack rock instead of the
    	Previous property to ensure we get over things like unbox.
    	[Backport of 120113]
    
    
    svn path=/branches/mono-2-2/mono-tools/; revision=120115
    Sebastien Pouliot committed Nov 27, 2008
  2. 2008-11-26 Sebastien Pouliot <sebastien@ximian.com>

    	* ConsiderUsingStopwatchTest.cs: Add test case where the values are
    	boxed (which can cause, using gmcs, an NRE in the rule).
    	[Backport of 120112]
    
    
    svn path=/branches/mono-2-2/mono-tools/; revision=120114
    Sebastien Pouliot committed Nov 27, 2008
Commits on Nov 25, 2008
  1. update installer with new logo and assemblies

    svn path=/branches/mono-2-2/mono-tools/; revision=119890
    Sebastien Pouliot committed Nov 25, 2008
  2. add missing test to build

    svn path=/branches/mono-2-2/mono-tools/; revision=119889
    Sebastien Pouliot committed Nov 25, 2008
  3. 2008-11-24 Sebastien Pouliot <sebastien@ximian.com>

    	* DetectNonAlphaNumericsInTypeNamesRule.cs: Move IsEnum check 
    	outside the loop.
    	[Backport r119887]
    
    
    svn path=/branches/mono-2-2/mono-tools/; revision=119888
    Sebastien Pouliot committed Nov 25, 2008
  4. 2008-11-24 Sebastien Pouliot <sebastien@ximian.com>

    	* AvoidUncalledPrivateCodeRule.cs: Simplify call into 
    	CheckAssemblyForMethodUsage
    	[Backport r119885]
    
    
    svn path=/branches/mono-2-2/mono-tools/; revision=119886
    Sebastien Pouliot committed Nov 25, 2008
  5. 2008-11-24 Sebastien Pouliot <sebastien@ximian.com>

    	* gendarme.svg: Update logo
    	* NEWS: Update with changes after preview 1
    	* Makefile.am: Add zip-bin and push targets
    
    
    svn path=/branches/mono-2-2/mono-tools/; revision=119884
    Sebastien Pouliot committed Nov 25, 2008
  6. update logo and fix filters

    svn path=/branches/mono-2-2/mono-tools/; revision=119883
    Sebastien Pouliot committed Nov 25, 2008
  7. 2008-11-22 Sebastien Pouliot <sebastien@ximian.com>

    	* DeserializeOptionalFieldRule.cs: Enable the rule only when
    	[OptionalField] is used/referenced inside a module (quite rare).
    	* UseCorrectSignatureForSerializationMethodsRule.cs: Enabled the
    	rule only when one of the On[Des|S]erializ[ed|ing]Attribute type
    	is referenced in the module (quite rare).
    	[Backport of r119701]
    
    
    svn path=/branches/mono-2-2/mono-tools/; revision=119881
    Sebastien Pouliot committed Nov 25, 2008
  8. 2008-11-18 Sebastien Pouliot <sebastien@ximian.com>

    	* DoNotHardcodePathsRule.cs: Specify StringComparison.Ordinal when 
    	calling StartsWith.
    	* MonoCompatibilityReviewRule.cs: Use HashSet instead of Dictionnary
    	for both NotImplementedInternal and MissingInternal since there is
    	no second argument (comments). Avoid calling ToString three times
    	(one per list) on MethodReference (which needs to rebuild the string
    	each time).
    	[Backport of 119258]
    
    
    svn path=/branches/mono-2-2/mono-tools/; revision=119880
    Sebastien Pouliot committed Nov 25, 2008
  9. 2008-11-18 Sebastien Pouliot <sebastien@ximian.com>

    	* MonoCompatibilityReviewTest.cs: Adjust test wrt rule changes.
    	[Backport of r119257]
    
    
    svn path=/branches/mono-2-2/mono-tools/; revision=119879
    Sebastien Pouliot committed Nov 25, 2008
  10. 2008-11-19 Sebastien Pouliot <sebastien@ximian.com>

    	* AvoidComplexMethodsRule.cs: Specify StringComparison.Ordinal when 
    	calling String.StartsWith.
    	* AvoidUnnecessarySpecializationRule.cs: Specify StringComparison.
    	Ordinal when calling String.StartsWith. Simplify namespace matching
    	method.
    	[Backport of r119414]
    
    
    svn path=/branches/mono-2-2/mono-tools/; revision=119877
    Sebastien Pouliot committed Nov 25, 2008
  11. 2008-11-20 Sebastien Pouliot <sebastien@ximian.com>

    	* AvoidRedundancyInMethodNameRule.cs: Specify StringComparison.Ordinal
    	when calling String.[Start|End]sWith. Use the new Exists method
    	from NamespaceEngine.
    	* AvoidRedundancyInTypeNameRule.cs: Specify StringComparison.Ordinal
    	when calling String.[Start|End]sWith.
    	* DoNotPrefixEventsWithAfterOrBeforeRule.cs: Specify 
    	StringComparison.Ordinal when calling String.StartsWith.
    	* DoNotUseReservedInEnumValueNamesRule.cs: Specify StringComparison.
    	Ordinal when calling String.IndexOf.
    	* UseCorrectSuffixRule.cs: Specify StringComparison.Ordinal when 
    	calling String.EndsWith.
    	[Backport of r119536]
    
    	* ParameterNamesShouldMatchOverridenMethodRule.cs: Do not issue 
    	false positives on macro-generated boo code.
    
    svn path=/branches/mono-2-2/mono-tools/; revision=119876
    Sebastien Pouliot committed Nov 25, 2008
  12. 2008-11-22 Sebastien Pouliot <sebastien@ximian.com>

    	* GetLastErrorMustBeCalledRightAfterPInvokeRule.cs: Fix the case
    	where we can't resolve the method (leading to a NRE).
    	[Backport of r119700]
    
    2008-11-18  Sebastien Pouliot  <sebastien@ximian.com> 
    
    	* GetLastErrorMustBeCalledRightAfterPInvokeRule.cs: Avoid calling 
    	ToString on Method[Reference|Definition] since they are rebuilt
    	each time. Accept UIntPtr [in]equality operators.
    	* MarshalBooleansInPInvokeDeclarationsRule.cs: Specify 
    	StringComparison.Ordinal when calling StartsWith.
    	* UseManagedAlternativesToPInvokeRule.cs: Remove PInvokeCall struct
    	since it required an allocation (of a new struct) in order to search
    	alternatives. This is now replaced by using strings and a second
    	check later for the module and runtime version.
    	[Backport of r119268]
    
    
    svn path=/branches/mono-2-2/mono-tools/; revision=119875
    Sebastien Pouliot committed Nov 25, 2008
  13. 2008-11-18 Sebastien Pouliot <sebastien@ximian.com>

    	* AvoidArgumentExceptionDefaultConstructorRule.cs: Specify 
    	StringComparison.Ordinal when calling EndsWith.
    	[Backport of r119253]
    
    
    svn path=/branches/mono-2-2/mono-tools/; revision=119874
    Sebastien Pouliot committed Nov 25, 2008
  14. 2008-11-20 Sebastien Pouliot <sebastien@ximian.com>

    	* AvoidRefAndOutParametersRule.cs: Specify StringComparison.Ordinal
    	when calling String.[Starts|Ends]With.
    	* ConsiderConvertingFieldToNullableRule.cs: Specify StringComparison.
    	Ordinal when calling String.EndsWith.
    	* ConsiderConvertingMethodToPropertyRule.cs: Specify 
    	StringComparison.Ordinal when calling String.EndsWith.
    	* ImplementIComparableCorreclyRule.cs: Apply the rule to types that
    	directly implement IComparable.
    	* InternalNamespacesShouldNotExposeTypesRule.cs: Specify 
    	StringComparison.Ordinal when calling String.EndsWith.
    	* PreferEventsOverMethodsRule.cs: Get method name out of the loop.
    	Specify StringComparison.Ordinal when calling String.StartsWith.
    	* TypesWithDisposableFieldsShouldBeDisposableRule.cs: Skip fields
    	type that are primitives or enums (as they wont be disposable).
    	[Backport of r119542]
    
    2008-11-15  Sebastien Pouliot  <sebastien@ximian.com>
    
    	* ConsiderAddingInterfaceRule.cs: Only check the current assembly 
    	or assemblies (from the set) that refers to the current assembly. 
    	Huge performance boost when a large number of assemblies are used.
    
    
    svn path=/branches/mono-2-2/mono-tools/; revision=119873
    Sebastien Pouliot committed Nov 25, 2008
  15. svn path=/branches/mono-2-2/mono-tools/; revision=119872

    Sebastien Pouliot committed Nov 25, 2008
  16. 2008-11-18 Sebastien Pouliot <sebastien@ximian.com>

    	* BadRecursiveInvocationRule.cs: Avoid calling Body.Instructions 
    	property chain so many times (24% of the calls to get_Body came
    	from here).
    	[Backport of r119252]
    
    
    svn path=/branches/mono-2-2/mono-tools/; revision=119871
    Sebastien Pouliot committed Nov 25, 2008
  17. 2008-11-23 Sebastien Pouliot <sebastien@ximian.com>

    	* DoNotForgetNotImplementedMethodsRule.cs: Turn off rule unless the
    	analyzed module refers to System.NotImplementedException (only 48 of
    	86 assemblies from Mono 2.0 profile do so).
    	* DoNotUseGetInterfaceToCheckAssignabilityRule.cs: Turn off the rule
    	unless the analyzed module refers to System.Type::GetInterface.
    
    2008-11-20  Sebastien Pouliot  <sebastien@ximian.com>
    
    	* AvoidCallingProblematicMethodsRule.cs: Rework SortedDictionary not
    	to require the full name, which avoid calling MethodReference so 
    	many times (each time creating a string).
    	* CloneMethodShouldNotReturnNullRule.cs: Only apply rules if the 
    	module refers to System.ICloneable (only 23 out of 86 assemblies 
    	of Mono 2.0 profile do). Change rule to IMethodRule since calling
    	Implements is rather expensive (recursive).
    	* DisableDebuggingCodeRule.cs: Specify StringComparison.Ordinal when
    	calling String.StartsWith.
    	* ReturnNullRule.cs: Change CheckMethod to virtual.
    	[Backport of r119557]
    
    
    svn path=/branches/mono-2-2/mono-tools/; revision=119870
    Sebastien Pouliot committed Nov 25, 2008
  18. 2008-11-20 Sebastien Pouliot <sebastien@ximian.com>

    	* CloneMethodShouldNotReturnNullTest.cs: Adjust fixture since the
    	rule now check methods.
    	[Backport of r119556]
    
    
    svn path=/branches/mono-2-2/mono-tools/; revision=119869
    Sebastien Pouliot committed Nov 25, 2008
  19. 2008-11-19 Sebastien Pouliot <sebastien@ximian.com>

    	* Namespace.cs: Specify StringComparison.Ordinal when calling
    	String.StartsWith.
    	[Backport r119411]
    
    
    svn path=/branches/mono-2-2/mono-tools/; revision=119868
    Sebastien Pouliot committed Nov 25, 2008
  20. 2008-11-19 Sebastien Pouliot <sebastien@ximian.com>

    	* NamespaceEngine.cs: Add Exists method to check the existance of
    	a namespace withint the assembly set.
    	[Backport of r119409]
    
    
    svn path=/branches/mono-2-2/mono-tools/; revision=119867
    Sebastien Pouliot committed Nov 25, 2008
  21. 2008-11-19 Sebastien Pouliot <sebastien@ximian.com>

    	* TypeRocks.cs: Make GetMethod smarter and check only the methods
    	or the constructors when possible. Split Implements in two parts
    	to remove some checks when recursion is needed. Also avoid recursion
    	for checking the base types. Add IsPrimitive rock.
    	[Backport of 119410]
    
    
    svn path=/branches/mono-2-2/mono-tools/; revision=119866
    Sebastien Pouliot committed Nov 25, 2008
  22. 2008-11-19 Sebastien Pouliot <sebastien@ximian.com>

    	* Rule.cs: Do not create a new Uri each time we ask for one (its 
    	not needed as it is read only).
    	* Runner.cs: Avoid needlessly calling IsVisible rock on types and 
    	methods when the runner is analyzing everything.
    	[Backport of r119412]
    
    
    svn path=/branches/mono-2-2/mono-tools/; revision=119865
    Sebastien Pouliot committed Nov 25, 2008
Commits on Nov 20, 2008
  1. * MonoWebBrowserHtmlRender.cs: Add printing support

    [Backported, r118687]
    
    2008-11-20  Andreia Gaita <shana@jitted.com>
    
    svn path=/branches/mono-2-2/mono-tools/; revision=119488
    shana committed Nov 20, 2008
  2. * MonoWebBrowserHtmlRender.cs: Update status bar when hovering over l…

    …inks
    
    [Backported, r118681]
    
    2008-11-20  Andreia Gaita <shana@jitted.com>
    
    svn path=/branches/mono-2-2/mono-tools/; revision=119487
    shana committed Nov 20, 2008
  3. * browser.cs: Probe for MonoWebBrowser before Gecko, as (1) Gecko is

      effectively unmaintained, (2) Gecko doesn't work on my machine, and
      (3) MonoWebBrowser suffers from neither (1) nor (2) (and it doubles
      as using our own dogfood, which is even better).
      [Backported, r118640]
    
    2008-11-20  Jonathan Pryor  <jpryor@novell.com>
    
    svn path=/branches/mono-2-2/mono-tools/; revision=119486
    shana committed Nov 20, 2008
  4. * browser.cs: Update usage

    * MonoWebBrowserHtmlRender.cs: Fix click handling, first load, image loading
    [Backported, r118613]
    
    2008-11-20  Andreia Gaita <shana@jitted.com>
    
    svn path=/branches/mono-2-2/mono-tools/; revision=119485
    shana committed Nov 20, 2008
Commits on Nov 14, 2008
  1. fix again

    svn path=/branches/mono-2-2/mono-tools/; revision=118824
    Sebastien Pouliot committed Nov 14, 2008
  2. VS2008 adjusted solution and projects (hopefully MD will still like t…

    …hem)
    
    svn path=/branches/mono-2-2/mono-tools/; revision=118818
    Sebastien Pouliot committed Nov 14, 2008
  3. Small changes to XML docs.

    svn path=/branches/mono-2-2/mono-tools/; revision=118816
    Sebastien Pouliot committed Nov 14, 2008