Typerocks IsNamed() errors #23

Merged
merged 3 commits into from Apr 28, 2013

Conversation

Projects
None yet
2 participants
Contributor

krijesta commented Feb 20, 2012

Currently TypeRocks.Match doesn't work correctly with NestedNested classes, TypeRocks.IsNamed(name, namespace) doesn't work with Nested classes and TypeRocks.IsNamed(fullName) will match on a shorter version of the typeName as the lenght to fix isn't matched. See commit messages:

Correct TypeRocks.IsNamed(TypeReference, string)

This corrects the match where a Type will match a substring of that type
e.g. the type "Test.Framework.Rocks.PublicType" would match the string
"Test.Framework.Rocks.P"
Correct IsNamed(TypeReference, string, string)

Fix usage when nested types are used. This removes the need for Match as
it can just be replaced by isNamed. Note that Match did not previously
work with nestednested types and now does

krijesta added some commits Feb 20, 2012

Add unit tests to TypeRocks for IsNamed
These unit tests currently fail
Correct TypeRocks.IsNamed(TypeReference, string)
This corrects the match where a Type will match a substring of that type
e.g. the type "Test.Framework.Rocks.PublicType" would match the string
"Test.Framework.Rocks.P"
Correct IsNamed(TypeReference, string, string)
Fix usage when nested types are used. This removes the need for Match as
it can just be replaced by isNamed. Note that Match did not previously
work with nestednested types and now does

spouliot added a commit that referenced this pull request Apr 28, 2013

Merge pull request #23 from krijesta/typerocks
Typerocks IsNamed() errors

@spouliot spouliot merged commit 49f6787 into mono:master Apr 28, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment